search

seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
75 stars 39 forks source link

line-height differerent from editor.citationstyles.org #61

Closed wapp-its closed 5 years ago

wapp-its commented 5 years ago

Stylesheet: apa.csl

The line-height is different between citeproc-php and editor.citationstyles.org. Problem is that the line height within one entry is the same as between multiple entries.

This is how it should look (margin between two entries and small line height within one entry): 2018-10-22 09_54_46-style info

This is how it looks with citeproc-php: 2018-10-22 10_01_40-publikationen _ fakultat fur psychologie

Because of the inline css: 2018-10-22 09_55_23-publikationen _ fakultat fur psychologie

We could override it with our css style-sheets, but in case this is not intended we will wait for a fix of citeproc-php. Eventually it's enough to simply remove the line-height ?

wapp-its commented 5 years ago

@seboettg happy new year!

Can you confirm this issue?

seboettg commented 5 years ago

I wouldn't define it as a bug, rather than as an improvement. If you interested in a quick solution, I would suggest you to make a PR. Afterwards, I might release a new version.

seboettg commented 5 years ago

Hi @wapp-its! I took a closer look to this issue. According to specification line-spacing specifies the vertical line distance and entry-spacing the vertical distance between entries. APA style for bibliographes preset a line-spacing of 2: <bibliography hanging-indent="true" et-al-min="8" et-al-use-first="6" et-al-use-last="true" entry-spacing="0" line-spacing="2">. Accordingly, citeproc-php behaves as expected. Or do you have another opinion?

seboettg commented 5 years ago

@wapp-its can you give me an answer? otherwise I'd close this ticket.

seboettg commented 5 years ago

I'm going to close this ticket for now. If there is still a need for action, please reopen the ticket.

wapp-its commented 5 years ago

Thanks for your investigation. You are right, this seems to be a correct behavior! In this case the CSL online editor has a bug.