search

seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
75 stars 39 forks source link

Closing parenthesis missing in BibTeX exports #72

Closed hllizi closed 4 years ago

hllizi commented 4 years ago

I'd briefly like to point out the two issues resolved in a perhaps rather brutish fashion here.

At two different places in the code it is ascertained that, when exporting to BibTeX, the last curly parenthesis will be missing in the resulting record if it should end with two parentheses, which is quite common, e.g.:

> @book{ ..., year={1978}}

Both issues were resolved by simply removing the application of the code that would prevent the doubling of parentheses, without any regard for the intended effects it might have in other places. Testing was not possible, unfortunately, since running the tests for both the original repository and my modifications resulted in a segmentation fault on my debian stretch machine.

At the moment, unfortunately, I do not have the resources to dig any deeper and must leave it at that.

seboettg commented 4 years ago

Hi David! I would suggest you send your changes as a pull request. I have integrated Scrutinizer CI for this repo. All tests should be executed automatically. Thus, we can see if your changes cause any side effects. It's also easier for me to work on your changes if necessary.

seboettg commented 4 years ago

Further discussions in PR73.