search

seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
75 stars 39 forks source link

PHP RFC: Deprecate curly brace syntax for accessing array elements and string offsets #78

Closed westcomputerconsultancy closed 4 years ago

westcomputerconsultancy commented 4 years ago

Afternoon,

There are a number of places where curly braces have been used as an array index. These are deprecated in php7.4. I've modified the files, rescanned in PHPCS and all seems to pass now.

Thanks,

Stephen

src.zip

westcomputerconsultancy commented 4 years ago

Pull request submitted.

seboettg commented 4 years ago

Hi @westcomputerconsultancy thanks for reporting this issue. Unfortunately, I had no time to take care of cireproc-php in the last few weeks. I'm going to solve this issues in the next days and make citeproc-php fit up to php 7.4.

westcomputerconsultancy commented 4 years ago

Thanks very much. It will help much.

On Mon, 30 Mar 2020, 19:15 Sebastian Böttger, notifications@github.com wrote:

Hi @westcomputerconsultancy https://github.com/westcomputerconsultancy thanks for reporting this issue. Unfortunately, I had no time to take care of cireproc-php in the last few weeks. I'm going to solve this issues in the next days and make citeproc-php fit up to php 7.4.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seboettg/citeproc-php/issues/78#issuecomment-606158970, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2KVDUEHZIUPYZKE3YDM6LRKDOUTANCNFSM4LLA2BRA .

seboettg commented 4 years ago

Hi @westcomputerconsultancy! I merged your pull request. Please also check if your issues are solved with the latest commit https://github.com/seboettg/citeproc-php/commit/6258cd9c49264a5bc1b357211a5c670b7da9d937 Thank you in advance!

westcomputerconsultancy commented 4 years ago

That's great. Many thanks. All seems to be working fine now with PHP7.4.

On Tue, 31 Mar 2020 at 17:18, Sebastian Böttger notifications@github.com wrote:

Hi @westcomputerconsultancy https://github.com/westcomputerconsultancy! I merged your pull request. Please also check if your issues are solved with the latest commit 6258cd9 https://github.com/seboettg/citeproc-php/commit/6258cd9c49264a5bc1b357211a5c670b7da9d937 Thank you in advance!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seboettg/citeproc-php/issues/78#issuecomment-606729610, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2KVDTIIZM5TBFLSZHB3Q3RKIJXFANCNFSM4LLA2BRA .

seboettg commented 4 years ago

Version 2.2.0 has been released. I think the issue should be solved. If not, feel free to reopen this ticket.