search

seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
75 stars 39 forks source link

Rendered html is invalid #89

Closed RazielleS closed 3 years ago

RazielleS commented 4 years ago

I have set up an example for you here: https://github.com/RazielleS/citeproc-bug-demo

In the second entry of the demo.json, we use a < in the title. This character is not replaced by its html equivalent (&lt;), so we get invalid XML out of this.

I do not think it should be necessary to encode the html entities in the Json directly, as I encountered other issues this way.

seboettg commented 4 years ago

Hi @RazielleS! Thank you for this bug report. My last commit should solve the issue. Please checkout the master branch, run composer update and test again. I'm going to prepare a new release, as soon as you confirm the fix.

seboettg commented 4 years ago

Hallo @RazielleS? Please check if the issue is solved.

RazielleS commented 4 years ago

Hi @seboettg Sorry, I was absent for a while.

I just tested with the master branch: This issue is solved. Thank you very much

seboettg commented 3 years ago

Solved with v2.2.1.