seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
75 stars 39 forks source link

... is reduced to . in citations #90

Closed RazielleS closed 3 years ago

RazielleS commented 4 years ago

I have set up an example for you here: https://github.com/RazielleS/citeproc-bug-demo

On the first entry in the demo.csl, there is a title with ... inside. This library converts this to only a single dot, which is not intended. I have tried with a demo on https://editor.citationstyles.org/searchByName/. There it does not cut out the dots.

seboettg commented 4 years ago

Hi @RazielleS! There is an UTF-8 character for "three dots" (HTML entity …) Simply replace '...' (three characters) by '…' (one character) and it will work as expected.

RazielleS commented 4 years ago

Hi @seboettg Thank you, I have changed it accordingly. This seems to work fine for now. Would be glad if this gets changed eventually though, so we can remove the replacement workaround in our codebase again.

seboettg commented 3 years ago

Hi @RazielleS, Shit in - shit out. To be honest, I don't see citeproc-php as having the responsibility to clean up bad input data. This is a bottomless pit. Especially since, depending on the application scenario, very different needs would arise. The scope of these requirements might justify a separate application.