search

sebp / scikit-survival

Survival analysis built on top of scikit-learn
GNU General Public License v3.0
1.12k stars 214 forks source link

[DOC] fix `GradientBoostingSurvivalAnalysis` docstring on `criterion` parameter #449

Closed fkiraly closed 6 months ago

fkiraly commented 6 months ago

Fixes https://github.com/sebp/scikit-survival/issues/448, under the assumption that the issue is with the docstring, not the logic.

fkiraly commented 6 months ago

of course, done

fkiraly commented 6 months ago

Thanks for noticing!

PS, it was actually the tests in skpro that noticed. Was churning through (assumed) parameter settings and it raised an error.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.15%. Comparing base (6782d8e) to head (a0cc3f4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #449 +/- ## ======================================= Coverage 98.15% 98.15% ======================================= Files 37 37 Lines 3526 3526 Branches 539 539 ======================================= Hits 3461 3461 Misses 31 31 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sebp commented 6 months ago

@fkiraly Thank you. Merged in commit f5e7c04

fkiraly commented 6 months ago

... why did you close this and merge a copy, @sebp?

sebp commented 6 months ago

I squashed your commits before merging.