search

sebsauvage / MinigalNano

GNU Affero General Public License v3.0
162 stars 50 forks source link

thumbs extension #109

Closed jimblue closed 8 years ago

jimblue commented 8 years ago

Hello

Is it "normal" that thumbs extension is ".jpg.jpg"

Doesn't look clean.

Can you help with that?

Thank you so much

nodiscc commented 8 years ago

There is nothing wrong with that. See also https://github.com/sebsauvage/MinigalNano/issues/110#issuecomment-210511811

jimblue commented 8 years ago

Ok @nodiscc but is it possible to have clean extension on thumb creation... It would be helpfull for me.

Thank you

nodiscc commented 8 years ago

If you need .jpg files (not .jpg.jpg) you can rename them after thumbnail creation, using a simple script (eg rename, or using your shell's substitution features - touch example.list; file=example.list; echo "${file%.*}"returns example), but Minigal expects the .jpg.jpg file. You can copy the renamed files with the new name instead of just renaming them, or just use symlinks.

Why do you need not-.jpg.jpg files?

jimblue commented 8 years ago

Hello :)

I don’t understand why Minigal need the .jpg.jpg Is there really no way to tell Minigal to look for simple .jpg ?

The problem for me is to have a clean extension first, but mainly for SEO as I use the name of my picture for referencing.

I also have a problem with rewriting rules, did you see my post on GIT ?

Thanks for you so much for your knowledge and your help.

Kind regards,

On 15 Apr 2016, at 23:36, nodiscc notifications@github.com wrote:

If you need .jpg files (not .jpg.jpg) you can rename them after thumbnail creation, using a simple script (eg rename http://man.cx/rename), but Minigal expects the .jpg.jpg file. You can copy the renamed files with the new name instead of just renaming them, or just use symlinks.

Why do you need not-.jpg.jpg files?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/sebsauvage/MinigalNano/issues/109#issuecomment-210657161

tmos commented 8 years ago

The point for minigal is, mainly technical : the thubs will be JPG, wathever the original format was. And here we can handle to display two files "a.jpg" and "a.png". Because their fullname is different, we will have "a.jpg.jpg" and "a.png.jpg".

If we remove the orignal file extension from the thumbnail name, we cannot make a difference between those two files, but this is right on a filesystem point of view to have "a.jpg" and "b.png" in the same folder.

So, you are here in a special case, we cannot make this dev in the project. I guess the best option is to do your modifications in your version.