sebsauvage / MinigalNano

GNU Affero General Public License v3.0
161 stars 50 forks source link

Pictures data binding #112

Open Draky50110 opened 8 years ago

Draky50110 commented 8 years ago

Hello.

Trying to add a comment file for one imagE. Name is ok but I put HTML language in it and... it is displayed as plain text.

So is it really HTML ? What exactly can we put in image_filename.hml ? What is "title:comment" tag ?

tmos commented 8 years ago

Hi @Draky50110

TL;DR : you can't setup proper html, it's filtered.

But, this issue is just revelant of a bigger problem : we really need to have a better system for the pictures comments.

Today, we have a mix of what you use here : a file with pic_name:comment, and also pic_name.ext.html.

None of them is easily usable, and I think, not very functional.

We should get rid of those old features, and setup a new and easy to use way of binding data to pictures.

I think that a CSV-like file would be a nice option.

So every picture would be identified by its name, in the first col, and we could get every data we want, in the other columns. We could setup some basic data (id, title, description), and let people use any data they want in their themes (lat, long, people_name, date, place,...). All of those informations could be used theme-side, without any modification of minigal code !

One CSV per folder could be a nice way of spliting data for performances.

What do you think about that ?

(ping to some people that may be interested on this issue : @nodiscc @Aldarone @sebsauvage )

Draky50110 commented 8 years ago

Personnaly, I don't have any idea about this :p Was just trying to add comments for some pictures and never succeed.

tmos commented 8 years ago

No problem, I just used your issue to go deeper on the issue origin. I think you can consider the current state of comments as broken if it doesn't work as-is.

Will be fixed in a near future :)

Draky50110 commented 8 years ago

Ok. I keep following notifications in this issue ;) Thanks :D

nodiscc commented 8 years ago

@tmos I think this is good idea; I'm just unsure about CSV as a storgae format. IMHO the requirements for the comments file should be: