search

sebsauvage / MinigalNano

GNU Affero General Public License v3.0
161 stars 50 forks source link

lightbox and EXIF rotation #39

Closed jniggemann closed 10 years ago

jniggemann commented 10 years ago

Replace the old mediabox 1.3.4 with the latest version, I tested with mediabox 1.5.4 and had no problems.

mediabox 1.5.4 contains a lot of updates and, more important, fixes.

tmos commented 10 years ago

Well, it is a good idea, but 1.5.x is a beta, so I don't really know how much it is finished… No problems for you ?

jniggemann commented 10 years ago

Oh, I didn't see that it's still beta... But no problems so far.

tmos commented 10 years ago

Actually, we plan to remove mediabox (even the beta have 2 years without updates…) for another lightbox plugin, more efficient on mobile. So I think we can keep the actual for the next few month.

jniggemann commented 10 years ago

It would be a very good idea to use a lightbox plugin that supports exif auto-orientation... If there's any, I have not yet checked.

tmos commented 10 years ago

Hey, I just got an idea :  Maybe it could be great, at the creation of the thumbnail (so, once by photo), to really turn the photo, save it, and then generate the thumbnail ! With this, one computing/image, done on server side, and no need to check at every load, in javascript. It seems a pretty good option for me, don't hesitate to tell me pro/cons.

tmos commented 10 years ago

With http://php.net/manual/en/function.imagerotate.php it could be pretty easy…

jniggemann commented 10 years ago

I don't think that's a good idea. I'd like to keep my pictures "as is", I would not want the display layer to change the data, so to speak. And IIRC, imagerotate is not lossless, which would be a no-go.

tmos commented 10 years ago

Yep, you are right. What about adding a class to the <img> in php with a rotation code (90°, 180°, etc.), and js will parse this, and rotate the photo. With this, we can take down some computing in client-side, and photos remain untouched.

jniggemann commented 10 years ago

Yes, that sounds better. I'd have guessed that there's already something out there, but even after quite some research I was unable to find a lightbox with built-in rotation capability...

tmos commented 10 years ago

This is the same for me : I made some research, but nothing at all… I think I'll adapt this one : http://brutaldesign.github.io/swipebox/

iGormilhit commented 10 years ago

Excuse me if I'm wrong, but I've never saw some rotation problem with MinigalNano. I mean, I'm managing the rotation with Excif data with Digikam and it's respected in MinigalNano. Maybe that's because Digikam writes the data in the files. Not all softwares are doing it. For example, I think Shotwell doesn't.

jniggemann commented 10 years ago

I mean, I'm managing the rotation with Excif data with Digikam and it's respected in MinigalNano. Do you have Digikams "AutoRotate" set? AFAIK Digikam automatically rotates pictures during import...

The orientation data is written by the camera, else Digikam wouldn't be able to properly autorotate on import (and entirely remove the orientation data after that [if you haven't configured it to retain the original {now wrong} value])...

iGormilhit commented 10 years ago

Ok, I still have a lot to understand and to learn about managing digital pictures... :(

I'm using Rapid-Photo-Downloader to import, but I can't find any setting about rotation. And when I'm shooting with a particuliar lens, there's only one orientation in the Excif metadata : landscape. So I have to "manually" rotate them with Digikam.

And the orientation is always "top, left", that's the dimensions which are changing, depending on the fact that's the picture is a landscape or a portrait.

But, I think I'm rotating the conversation in the wrong direction, so I will let you go on... :)

tmos commented 10 years ago

I close this issue, as we plan to remove mediabox in a near future.