search

sebsauvage / MinigalNano

GNU Affero General Public License v3.0
161 stars 50 forks source link

No right click menu on lightbox #94

Closed nodiscc closed 9 years ago

nodiscc commented 9 years ago

Since a recent update, right click menu is disabled on the images in lightbox. I'm no longer able to use View image or Save image as. Any idea how to fix this?

10cre commented 9 years ago

Same for me. It would be great to have the right click available again to save the photos. If you can't please add a download link.

10cre commented 9 years ago

Ok, I know how to fix this. Edit js/mediabox1.5.4 on line 106 change "true" to "false" ;-) clickBlock: false

jniggemann commented 9 years ago

Yep, this is a feature of mediabox.js. Please close this issue and label it as "wontfix" or "NotABug" or something like that.

nodiscc commented 9 years ago

Yep, this is a feature of mediabox.js.

This is definitely a bug for me in an image gallery. Right click menu should not be manipulated silently, Save image, Diplay image, copy image URL to clipboard etc. are expected features. What purpose does it serve (other than uneffective image copy protection)?

Can we please instead switch this pref to false by default?

jniggemann commented 9 years ago

Personally, I don't care about this setting. IMHO this is a regression of 4df42d9, I probably introduced it when I updated mediabox advanced... I updated the PR.

nodiscc commented 9 years ago

Thanks @jniggemann @10cre

jniggemann commented 9 years ago

@indoushka Don't hijack existing issues, please open a new one.