Space in tags - Githubissues

sebsauvage commented 11 years ago

Most other bookmarking systems support spaces in tags. Shaarli doesn't.

Tag separator in Shaarli should not be space, but comma (,).

dsferruzza commented 11 years ago

I think the main difficulty in this feature is to provide a simple way to update the tag separator in existing data.

Some possibilities:

admin choose tag separator in the config page
admin choose tag separator by editing index.php
update of existing tags is done by editing each link manually
update of existing tags is done automatically when the config page is submitted ; this process has to handle the case where the new tag separator character is already used in tags (a solution could be to replace it by the old tag separator)

What do you think?

respencer commented 11 years ago

I think this is a bad idea. I don't understand the fascination of some people to use entire sentences as tags. Tags are supposed to be short and sweet.

Please keep whitespace and comma's out of tags.

My reasoning:

The spacebar is the easiest key to hit and the most natural for separation. There's no reason why we can't also support comma's as a tag separator (both at the same time). I can't think of any reason anyone would want a comma in a tag.
Being forced to glue words together if you want long tags is actually beneficial, super_long_tags_look_stupid, which encourages brevity.
If I want to delete this_word, I can just double-click on it and press delete. If it was 2 words separated by whitespace I'd have to carefully manually select it with the mouse (extra sucky doing that on a tablet).
And finally you needlessly complicate API support. Keeping whitespace and comma's out of tags makes it easy to support the Delicious v1 API in future and tools that use that API.

PatrickHonorez commented 11 years ago

Robert, Some people (like me) happen to have tags like "Visual Studio" or "CRM Dynamics" in, let's say, Google Bookmarks. I would gladly migrate to Shaarli, but I want to keep all my existing information intact. Not being able to properly import my existing bookmarks is simply a show stopper.

Patrick Honorez +352 691-67 68-65

On 5 July 2013 13:55, Robert Spencer notifications@github.com wrote:

I think this is a bad idea. I don't understand the fascination of some people to use entire sentences as tags. Tags are supposed to be short and sweet.

Please keep whitespace and comma's out of tags.

My reasoning:

-

The spacebar is the easiest key to hit and the most natural for separation. There's no reason why we can't also support comma's as a tag separator (both at the same time). I can't think of any reason any one would want a comma in a tag.

Being forced to glue words together if you want long tags is actually beneficial, super_long_tags_look_stupid, which encourages brevity.

If I want to delete this_word, I can just double-click on it and press delete. If it was 2 words separated by whitespace I'd have to carefully manually select it with the mouse (extra sucky doing that on a tablet).

And finally you needlessly complicate API support. Keeping whitespace and comma's out of tags makes it easy to support the Delicious v1 API in future and tools that use that API.

— Reply to this email directly or view it on GitHubhttps://github.com/sebsauvage/Shaarli/issues/22#issuecomment-20515444 .

respencer commented 11 years ago

Replacing spaces with underscore wouldn't destroy your information. It would only really suck if the default response on import is to kill spaces. VisualStudio is passable, CRMDynamics is not.

PatrickHonorez commented 11 years ago

Replacing spaces with underscores is fine if automated during import. If it has to be done in the file before import, I am not sure that it's in Mr.Everyone competencies. Risk is high to replace "other" spaces.

Patrick Honorez +352 691-67 68-65

On 5 July 2013 14:25, Robert Spencer notifications@github.com wrote:

Replacing spaces with underscore wouldn't destroy your information. It would only really suck if the default response on import is to kill spaces. VisualStudio is passable, CRMDynamics is not.

— Reply to this email directly or view it on GitHubhttps://github.com/sebsauvage/Shaarli/issues/22#issuecomment-20516462 .

ghost commented 11 years ago

Is there any progress with this enhancement? I have an owncloud server and their bookmark manager supports tags with spaces. While I prefer the layout of Shaarli, I want tags with spaces and will move my data over if necessary.

EDIT: I exported my existing bookmarks.I used sijnak's update from above and renamed the data store so a new blank data store would be created. I then imported my bookmarks and my tags were brought in separated by commas.

magicvince commented 11 years ago

+1 for this enhancement Geek users have no problem with camel case or using underscore but it's not really a solution. Using coma instead of space for separation between tags is nice.

Thanks Seb for your job

sebsauvage / Shaarli

Space in tags #22

The spacebar is the easiest key to hit and the most natural for separation. There's no reason why we can't also support comma's as a tag separator (both at the same time). I can't think of any reason any one would want a comma in a tag.

Being forced to glue words together if you want long tags is actually beneficial, super_long_tags_look_stupid, which encourages brevity.

If I want to delete this_word, I can just double-click on it and press delete. If it was 2 words separated by whitespace I'd have to carefully manually select it with the mouse (extra sucky doing that on a tablet).