search

sebshader / pdnext

Color-themed Pure data with different inlets & outlets for messages and signals
Other
45 stars 3 forks source link

GUI object labels are black in dark themes #17

Closed jamshark70 closed 1 year ago

jamshark70 commented 1 year ago

Just trying this out -- installation was relatively painless, thanks!

I did observe that slider, toggle etc. labels are black even in dark themes. No time at the moment to dig into it but that would be a nice detail to adjust.

Great stuff here!

sebshader commented 1 year ago

Hi @jamshark70, Right now I don't mess with any of the 'iemgui' stuff because the colors can be set from messages/properties, and I want to break distributed abstractions as little as possible. (this is already a bit of an issue w/ gatoms: symbol box, number box, & list box. But at least those can be set to a dark color to work w/ abstractions from vanilla if desired, and if a background color is set the content itself will still be visible regardless.) I think the basic issue is: it is impossible to know if an item is being created from the menu (or dynamically) or being loaded from a patch. Even if it is loaded from a patch the items would then have to be the default colors in the case of using them on a regular canvas, so this issue would persist. In addition since these objects save their colors they wouldn't change if the theme changes. I'm going to close this for now until some solution presents itself. Maybe color could be set if outside a 'graph on parent' or something like that..

sebshader commented 1 year ago

I'm also going to transfer this to pd-next because this is an issue w/ pd-next core, not the color-theme plugin. Also duplicate of #5 (& #14)