sebsoftnl / moodle-enrol_gwpayments

Other
2 stars 3 forks source link

Avoid empty lib.php file #4

Closed mudrd8mz closed 3 years ago

mudrd8mz commented 3 years ago

https://github.com/sebsoftnl/moodle-enrol_gwpayments/blob/30a0d63381473358392acea36bd119ddfd48f863/lib.php

rogiervandongen commented 3 years ago

@mudrd8mz After having resolved this we came to a shocking conclusion: the lib.php file is explicitly mandated by the function "enrol_get_instances() in enrollib.php; hence it's added back.

mudrd8mz commented 3 years ago

Oh! Well spotted. Sorry I was not aware. I am sure this is actually a relic in the Moodle core from the times when the lib.php was the only place where the enrolment plugin class could be provided. I'll raise and MDL for this. Feel free to ignore this for now and thank you again.