modules.js included when no coupon functionality used

sebsoftnl / moodle-enrol_gwpayments

Other

2 stars 3 forks source link

modules.js included when no coupon functionality used #6

Closed rogiervandongen closed 2 years ago

rogiervandongen commented 2 years ago

When the coupon functionality is not used, the module.js is loaded nonetheless. This causes a javascript error because the intended HTML element is not found.

Solution should be: do not load module.js when the coupon functionality isn't in use (logic in mustache template) and prevent loading of resources when not needed.

rogiervandongen commented 2 years ago

Autoclosing on next release (it was actually already fixed in https://github.com/sebsoftnl/moodle-enrol_gwpayments/commit/0dd0aa5e4de35f1c23b3c551774c390e4e313bcd)