sec-gov / oh

Repository for the schema, sample files, and PDF renderer required under 17 CFR 242.606(a)(1), 242.606(b)(1), and 242.606(b)(3). Branch "marked-pdf" corresponds to the 19/Dec/2020 update that makes rendered PDF compliant with PDF/UA.
Other
2 stars 4 forks source link

606a1_held_order_public_report Summary table values not displayed when convert to PDF #7

Closed LaiFaiLee closed 3 years ago

LaiFaiLee commented 3 years ago

Hello,

After some initial testing with the new XML schema published on 12/19/2020, we are finding that the Summary section is not properly populating – it is populating with blanks(--) on the 606a1_held_order_public_report. We expect these fields to be populated with numeric values.

This is the filename in question:

In the oh-20201219 folder- File Name Rule606ReportGenerator.js Line Number: 813

Current SEC Code published on 12/19/2020: function getPublicRoutingBody(section, monthVal, year) { // a1 var empty = true; for (var i=0;i<a1SummaryTableTags[i];i++) { if (NS != getElementValueByMonth(a1SummaryTableTags[i],section, monthVal, year)) { empty = false; break; } }

Tweak by our development team : This minor tweak on Line 813 appears to resolve the display issue. function getPublicRoutingBody(section, monthVal, year) { // a1 var empty = true; for (var i=0;i<a1SummaryTableTags.length;i++) { if (NS != getElementValueByMonth(a1SummaryTableTags[i],section, monthVal, year)) { empty = false; break; } } Thank you

sec-gov commented 3 years ago

Fixed, thanks

From: LaiFaiLee notifications@github.com Sent: Friday, January 08, 2021 3:25 PM To: sec-gov/oh oh@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [sec-gov/oh] 606a1_held_order_public_report Summary table values not displayed when convert to PDF (#7)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

After some initial testing with the new XML schema published on 12/19/2020, we are finding that the Summary section is not properly populating – it is populating with blanks(--) on the 606a1_held_order_public_report. We expect these fields to be populated with numeric values.

This is the filename in question:

In the oh-20201219 folder- File Name Rule606ReportGenerator.js Line Number: 813

Current SEC Code published on 12/19/2020: function getPublicRoutingBody(section, monthVal, year) { // a1 var empty = true; for (var i=0;i<a1SummaryTableTags[i];i++) { if (NS != getElementValueByMonth(a1SummaryTableTags[i],section, monthVal, year)) { empty = false; break; } }

Tweak by our development team : This minor tweak on Line 813 appears to resolve the display issue. function getPublicRoutingBody(section, monthVal, year) { // a1 var empty = true; for (var i=0;i<a1SummaryTableTags.length;i++) { if (NS != getElementValueByMonth(a1SummaryTableTags[i],section, monthVal, year)) { empty = false; break; } } Thank you

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=4272d1bf-1de9e949-42723509-8681010e5614-25ab554486cdd961&q=1&e=7aca3e41-39a2-48ef-b15a-8940f94c6632&u=https%3A%2F%2Fgithub.com%2Fsec-gov%2Foh%2Fissues%2F7, or unsubscribehttps://protect2.fireeye.com/v1/url?k=8214b6a9-dd8f8e5f-8214521f-8681010e5614-550d37b6260e1659&q=1&e=7aca3e41-39a2-48ef-b15a-8940f94c6632&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARUGWDA3P5EOP5STPW6UXATSY5SYVANCNFSM4V25P4SQ.

LaiFaiLee commented 3 years ago

Hello,

Thank you for the prompt response. Is the fix only within the source code file? We just checked the link on the https://www.sec.gov/structureddata/dera_taxonomies this still contains the Report Renderer from 12/19/2020. Will a new version be published soon?

[cid:image001.png@01D6E814.95AFBA80]

Thanks, Lai Fai Lee From: US Securities and Exchange Commission notifications@github.com Sent: Friday, January 8, 2021 7:29 PM To: sec-gov/oh oh@noreply.github.com Cc: Lee, Lai-Fai lai-fai.lee@fmr.com; Author author@noreply.github.com Subject: Re: [sec-gov/oh] 606a1_held_order_public_report Summary table values not displayed when convert to PDF (#7)

This email is from an external source - exercise caution regarding links and attachments.

Fixed, thanks

From: LaiFaiLee notifications@github.com<mailto:notifications@github.com> Sent: Friday, January 08, 2021 3:25 PM To: sec-gov/oh oh@noreply.github.com<mailto:oh@noreply.github.com> Cc: Subscribed subscribed@noreply.github.com<mailto:subscribed@noreply.github.com> Subject: [sec-gov/oh] 606a1_held_order_public_report Summary table values not displayed when convert to PDF (#7)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

After some initial testing with the new XML schema published on 12/19/2020, we are finding that the Summary section is not properly populating – it is populating with blanks(--) on the 606a1_held_order_public_report. We expect these fields to be populated with numeric values.

This is the filename in question:

In the oh-20201219 folder- File Name Rule606ReportGenerator.js Line Number: 813

Current SEC Code published on 12/19/2020: function getPublicRoutingBody(section, monthVal, year) { // a1 var empty = true; for (var i=0;i<a1SummaryTableTags[i];i++) { if (NS != getElementValueByMonth(a1SummaryTableTags[i],section, monthVal, year)) { empty = false; break; } }

Tweak by our development team : This minor tweak on Line 813 appears to resolve the display issue. function getPublicRoutingBody(section, monthVal, year) { // a1 var empty = true; for (var i=0;i<a1SummaryTableTags.length;i++) { if (NS != getElementValueByMonth(a1SummaryTableTags[i],section, monthVal, year)) { empty = false; break; } } Thank you

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=4272d1bf-1de9e949-42723509-8681010e5614-25ab554486cdd961&q=1&e=7aca3e41-39a2-48ef-b15a-8940f94c6632&u=https%3A%2F%2Fgithub.com%2Fsec-gov%2Foh%2Fissues%2F7, or unsubscribehttps://protect2.fireeye.com/v1/url?k=8214b6a9-dd8f8e5f-8214521f-8681010e5614-550d37b6260e1659&q=1&e=7aca3e41-39a2-48ef-b15a-8940f94c6632&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARUGWDA3P5EOP5STPW6UXATSY5SYVANCNFSM4V25P4SQ.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sec-gov/oh/issues/7#issuecomment-757061167, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASMYPIYXJAUAQ34ONLOYNQLSY6PL7ANCNFSM4V25P4SQ.

sec-gov commented 3 years ago

Yes, and yes.

From: LaiFaiLee notifications@github.com Sent: Monday, January 11, 2021 12:24 PM To: sec-gov/oh oh@noreply.github.com Cc: Hamscher, Walter HamscherW@sec.gov; State change state_change@noreply.github.com Subject: Re: [sec-gov/oh] 606a1_held_order_public_report Summary table values not displayed when convert to PDF (#7)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

Thank you for the prompt response. Is the fix only within the source code file? We just checked the link on the https://www.sec.gov/structureddata/dera_taxonomies this still contains the Report Renderer from 12/19/2020. Will a new version be published soon?

[cid:image001.png@01D6E814.95AFBA80]

Thanks, Lai Fai Lee From: US Securities and Exchange Commission notifications@github.com<mailto:notifications@github.com> Sent: Friday, January 8, 2021 7:29 PM To: sec-gov/oh oh@noreply.github.com<mailto:oh@noreply.github.com> Cc: Lee, Lai-Fai lai-fai.lee@fmr.com<mailto:lai-fai.lee@fmr.com>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [sec-gov/oh] 606a1_held_order_public_report Summary table values not displayed when convert to PDF (#7)

This email is from an external source - exercise caution regarding links and attachments.

Fixed, thanks

From: LaiFaiLee notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> Sent: Friday, January 08, 2021 3:25 PM To: sec-gov/oh oh@noreply.github.com<mailto:oh@noreply.github.com<mailto:oh@noreply.github.com%3cmailto:oh@noreply.github.com>> Cc: Subscribed subscribed@noreply.github.com<mailto:subscribed@noreply.github.com<mailto:subscribed@noreply.github.com%3cmailto:subscribed@noreply.github.com>> Subject: [sec-gov/oh] 606a1_held_order_public_report Summary table values not displayed when convert to PDF (#7)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

After some initial testing with the new XML schema published on 12/19/2020, we are finding that the Summary section is not properly populating – it is populating with blanks(--) on the 606a1_held_order_public_report. We expect these fields to be populated with numeric values.

This is the filename in question:

In the oh-20201219 folder- File Name Rule606ReportGenerator.js Line Number: 813

Current SEC Code published on 12/19/2020: function getPublicRoutingBody(section, monthVal, year) { // a1 var empty = true; for (var i=0;i<a1SummaryTableTags[i];i++) { if (NS != getElementValueByMonth(a1SummaryTableTags[i],section, monthVal, year)) { empty = false; break; } }

Tweak by our development team : This minor tweak on Line 813 appears to resolve the display issue. function getPublicRoutingBody(section, monthVal, year) { // a1 var empty = true; for (var i=0;i<a1SummaryTableTags.length;i++) { if (NS != getElementValueByMonth(a1SummaryTableTags[i],section, monthVal, year)) { empty = false; break; } } Thank you

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=4272d1bf-1de9e949-42723509-8681010e5614-25ab554486cdd961&q=1&e=7aca3e41-39a2-48ef-b15a-8940f94c6632&u=https%3A%2F%2Fgithub.com%2Fsec-gov%2Foh%2Fissues%2F7, or unsubscribehttps://protect2.fireeye.com/v1/url?k=8214b6a9-dd8f8e5f-8214521f-8681010e5614-550d37b6260e1659&q=1&e=7aca3e41-39a2-48ef-b15a-8940f94c6632&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARUGWDA3P5EOP5STPW6UXATSY5SYVANCNFSM4V25P4SQ.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sec-gov/oh/issues/7#issuecomment-757061167<https://protect2.fireeye.com/v1/url?k=129c5b35-4d076227-129cbf83-86b2e136ff17-79439db21d5aff43&q=1&e=ace55a7b-8649-4822-a92e-c62ca9fbf5e4&u=https%3A%2F%2Fgithub.com%2Fsec-gov%2Foh%2Fissues%2F7%23issuecomment-757061167>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASMYPIYXJAUAQ34ONLOYNQLSY6PL7ANCNFSM4V25P4SQ<https://protect2.fireeye.com/v1/url?k=3a81b1c0-651a88d2-3a815576-86b2e136ff17-3441463932ce9542&q=1&e=ace55a7b-8649-4822-a92e-c62ca9fbf5e4&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASMYPIYXJAUAQ34ONLOYNQLSY6PL7ANCNFSM4V25P4SQ>.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=c7c55dd2-985e64c0-c7c5b964-86b2e136ff17-6bde9a37134fde6c&q=1&e=ace55a7b-8649-4822-a92e-c62ca9fbf5e4&u=https%3A%2F%2Fgithub.com%2Fsec-gov%2Foh%2Fissues%2F7%23issuecomment-758101025, or unsubscribehttps://protect2.fireeye.com/v1/url?k=7d011e2a-229a2738-7d01fa9c-86b2e136ff17-bf3acb585d8307ea&q=1&e=ace55a7b-8649-4822-a92e-c62ca9fbf5e4&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARUGWDAEOJY3GECB35KR4X3SZMX2ZANCNFSM4V25P4SQ.