secabstraction / PowerWalker

BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

Not exactly an issue. #2

Open adoshev92 opened 3 years ago

adoshev92 commented 3 years ago

Thank you for this repository! I dreaded importing all the functions to c#. So far I've been using c++/cli but this adds a lot of extra code which is prone to bugs. Anyways, I wanted to suggest a few improvements. It is not an issue here because you are not setting a symbol server but if you did, initializing the symbols on each stacktrace would be really slow. Initializing them just once and then passing the hProcess to the StackTrace function is much faster. Also, there is no reason to call LoadModules() as SymInitialize() does that for you. Setting the SYMOPT_DEFERRED_LOADS flag is also a great improvement. I would love to make a PR if you wish.