search

seccomp / libseccomp

The main libseccomp repository
GNU Lesser General Public License v2.1
799 stars 171 forks source link

RFE: add the SCMP_FLTATR_CTL_WAITKILL filter attribute #391

Closed pcmoore closed 1 year ago

pcmoore commented 2 years ago

The SCMP_FLTATR_CTL_WAITKILL attribute requests that the SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV flag be passed to the seccomp(2) system call when possible, which is currently only when the SECCOMP_FILTER_FLAG_NEW_LISTENER flag is also set.

Resolves #387

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.03%) to 89.71% when pulling 1bcbe5d2a7404f9807739e4dfc98c2ffbf7778dc on pcmoore:gh-387 into e797591bdd6834272e2db292400f608ed9bd7fab on seccomp:main.

pcmoore commented 2 years ago

Hold off on reviewing/ACK'ing this PR, I had a thought this morning that we might also need to bump the API level for this; I'll check that and update this PR later today (hopefully).

pcmoore commented 2 years ago

Okay, fixed. I added API level 7 to match with the new flag.

drakenclimber commented 1 year ago

Thanks, @pcmoore

drakenclimber commented 1 year ago

Pushed to main in commit 96989965042a. Thanks, @pcmoore

pcmoore commented 1 year ago

Thanks @drakenclimber, I've had limited network access the past few weeks but things should be getting back to normal next week ... once I get caught up ;)

drakenclimber commented 1 year ago

Thanks @drakenclimber, I've had limited network access the past few weeks but things should be getting back to normal next week ... once I get caught up ;)

@pcmoore, No worries. Let me know if you need any help or there's anything you want me to pick up.