BUG: gcc warning in gen_bpf.c

[drakenclimber]

gen_bpf.c: In function '_gen_bpf_build_bpf':
gen_bpf.c:2077:21: warning: storing the address of local variable 'pseudo_arch' in '*state.arch' [-Wdangling-pointer=]
 2077 |         state->arch = &pseudo_arch;
      |         ~~~~~~~~~~~~^~~~~~~~~~~~~~
gen_bpf.c:1999:25: note: 'pseudo_arch' declared here
 1999 |         struct arch_def pseudo_arch;
      |                         ^~~~~~~~~~~
gen_bpf.c:1985:49: note: 'state' declared here
 1985 | static int _gen_bpf_build_bpf(struct bpf_state *state,
      |                               ~~~~~~~~~~~~~~~~~~^~~~~

[drakenclimber]

GCC complains about storing a pointer to a local stack variable in a struct that is used outside of _gen_bpf_build_bpf(). While the state struct is used after _gen_bpf_build_bpf() returns, the state->arch variable is not.

So we should clean this up, but it's not currently being used improperly.

[xen0n]

Triage: this seems already fixed by commit 31583fab12370da984785cd16ceb8f031c94ae76.

[pcmoore]

FWIW, I'm not seeing this either with HEAD at 2847f10dddca72167309c04cd09f326fd3b78e2f and GCC v14.2.1, @drakenclimber are you still seeing this warning?