search

seccomp / libseccomp

The main libseccomp repository
GNU Lesser General Public License v2.1
810 stars 173 forks source link

BUG: avoid use of non-portable `which` in the tests #424

Closed thesamesam closed 10 months ago

thesamesam commented 11 months ago

which is not a standard POSIX utility, and indeed, each of these test scripts uses #!/bin/bash as its shebang, so we can use type -P which has the same behaviour as which for free.

(If the tests used POSIX shell, we could do command -v, its only caveat is that it'll pick up functions in the user's shell, which doesn't matter 99% of the time anyway.)

Distributions like Debian [0] and Gentoo [1] are looking to remove which from their base set of packages.

[0] https://lwn.net/Articles/874049/ [1] https://bugs.gentoo.org/646588

pcmoore commented 10 months ago

Hi @thesamesam, first off, great branch name :)

Other than that, this patch looks good to me, and considering the trivial nature I'm going to go ahead and merge this into main via 47ca6441d62e41ba845ad8036c15f1154bd56b24. @drakenclimber if you have any concerns/objections please let me know and we can fix things up, or revert this patch if needed.

Thanks all!