search

seccomp / libseccomp

The main libseccomp repository
GNU Lesser General Public License v2.1
795 stars 171 forks source link

BUG: only use bogus syscall numbers in test 29 #436

Open pcmoore opened 1 week ago

pcmoore commented 1 week ago

The goal of test 29 is to test bogus negative syscall numbers, unfortunately it appears our choice of syscalls was not bogus on all the architectures we support. This commit fixes that by picking a syscall number well outside the pseudo-syscall/PNR range and removing the sysmips(2) syscall from the test so as to not cause problems at a later date.

pcmoore commented 1 week ago

Test results:

% uname -m
aarch64
% ./regression -b 29-sim-pseudo_syscall
=============== Thu Sep  5 05:40:40 PM EDT 2024 ===============
Regression Test Report ("regression -b 29-sim-pseudo_syscall")
 batch name: 29-sim-pseudo_syscall
 test mode:  c
 test type:  bpf-sim
Test 29-sim-pseudo_syscall%%001-00001 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00002 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00003 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00004 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00005 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00006 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00007 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00008 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00009 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00010 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00011 result:   SUCCESS
Test 29-sim-pseudo_syscall%%002-00001 result:   SUCCESS
 test mode:  c
 test type:  bpf-valgrind
Test 29-sim-pseudo_syscall%%003-00001 result:   SUCCESS
 batch name: 29-sim-pseudo_syscall
 test mode:  python
 test type:  bpf-sim
Test 29-sim-pseudo_syscall%%001-00001 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00002 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00003 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00004 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00005 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00006 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00007 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00008 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00009 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00010 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00011 result:   SUCCESS
Test 29-sim-pseudo_syscall%%002-00001 result:   SUCCESS
 test mode:  python
 test type:  bpf-valgrind
Test 29-sim-pseudo_syscall%%003-00001 result:   SKIPPED (only valid in native/c mode)
Regression Test Summary
 tests run: 25
 tests skipped: 1
 tests passed: 25
 tests failed: 0
 tests errored: 0
============================================================
% uname -m
x86_64
% ./regression -b 29-sim-pseudo_syscall
=============== Thu Sep  5 05:41:59 PM EDT 2024 ===============
Regression Test Report ("regression -b 29-sim-pseudo_syscall")
 batch name: 29-sim-pseudo_syscall
 test mode:  c
 test type:  bpf-sim
Test 29-sim-pseudo_syscall%%001-00001 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00002 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00003 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00004 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00005 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00006 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00007 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00008 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00009 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00010 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00011 result:   SUCCESS
Test 29-sim-pseudo_syscall%%002-00001 result:   SUCCESS
 test mode:  c
 test type:  bpf-valgrind
Test 29-sim-pseudo_syscall%%003-00001 result:   SUCCESS
 batch name: 29-sim-pseudo_syscall
 test mode:  python
 test type:  bpf-sim
Test 29-sim-pseudo_syscall%%001-00001 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00002 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00003 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00004 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00005 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00006 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00007 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00008 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00009 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00010 result:   SUCCESS
Test 29-sim-pseudo_syscall%%001-00011 result:   SUCCESS
Test 29-sim-pseudo_syscall%%002-00001 result:   SUCCESS
 test mode:  python
 test type:  bpf-valgrind
Test 29-sim-pseudo_syscall%%003-00001 result:   SKIPPED (only valid in native/c mode)
Regression Test Summary
 tests run: 25
 tests skipped: 1
 tests passed: 25
 tests failed: 0
 tests errored: 0
============================================================
coveralls commented 1 week ago

Coverage Status

coverage: 89.454%. remained the same when pulling a76ff1771cad89333300ea950e69c27fcbaa2396 on pcmoore:gh-418 into 2847f10dddca72167309c04cd09f326fd3b78e2f on seccomp:main.