search

secdev / scapy

Scapy: the Python-based interactive packet manipulation program & library.
https://scapy.net
GNU General Public License v2.0
10.6k stars 2.01k forks source link

Fix minor parsing issue in NBNS query response #4406

Closed gpotter2 closed 3 months ago

gpotter2 commented 4 months ago

some combinations of flags would get missed when dissecting

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.55%. Comparing base (640252e) to head (ef7b6a9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4406 +/- ## ========================================== - Coverage 81.56% 81.55% -0.01% ========================================== Files 352 352 Lines 83995 83997 +2 ========================================== - Hits 68513 68507 -6 - Misses 15482 15490 +8 ``` | [Files](https://app.codecov.io/gh/secdev/scapy/pull/4406?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev) | Coverage Δ | | |---|---|---| | [scapy/layers/netbios.py](https://app.codecov.io/gh/secdev/scapy/pull/4406?src=pr&el=tree&filepath=scapy%2Flayers%2Fnetbios.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev#diff-c2NhcHkvbGF5ZXJzL25ldGJpb3MucHk=) | `92.53% <100.00%> (+0.11%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/secdev/scapy/pull/4406/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev)