Open christian-sahlmann opened 2 weeks ago
Attention: Patch coverage is 40.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 80.39%. Comparing base (
6b26ace
) to head (ea01a92
). Report is 7 commits behind head on master.
Could you share details about your setup? What OS / version are affected?
My problem is that I'm stuck (at least for now) with a pretty old linux kernel (3.10.0-1160.45.1.el7.x86_64). So far, scapy worked perfectly fine there for my purposes (and does again with this fix).
I did a little bit more research and found out that the minimum version for this to work is Linux 4.12.
See https://github.com/torvalds/linux/commit/2d4bc93368f5a0ddb57c8c885cdad9c9b7a10ed5
That's interesting thanks. What if you just try: except: pass this request, does it work on your linux version? From what I understand Scapy shouldn't need extended ack reporting to work.
Yes, I've tried that as well, but then I get an exception at sock.setsockopt(SOL_NETLINK, NETLINK_GET_STRICT_CHK, 1)
, which apparently is available only since Linux 4.20 (https://github.com/torvalds/linux/commit/89d35528d17d25819a755a2b52931e911baebc66).
Alright, thanks for the pointers.
I'll pop a VM with a Linux 3.0 kernel and investigate to see what we can do, and get back to you.
I can't really merge this PR because it's just a workaround. Scapy should have a way of reading routes on old linux kernels, as it used to. If it happens that RTNETLINK really isn't supported, we'll add a fallback to some other method.
I was getting this error after https://github.com/secdev/scapy/pull/4352 was merged: