secdev / scapy

Scapy: the Python-based interactive packet manipulation program & library.
https://scapy.net
GNU General Public License v2.0
10.29k stars 1.99k forks source link

Check if the Data field exists #4432

Closed guedou closed 1 week ago

guedou commented 2 weeks ago

Here is a fix for an OSS-fuzz finding.

@gpotter2 could you have a look?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.48%. Comparing base (06afa39) to head (6190e8b). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4432 +/- ## ========================================== - Coverage 82.10% 81.48% -0.63% ========================================== Files 353 353 Lines 84300 84300 ========================================== - Hits 69214 68689 -525 - Misses 15086 15611 +525 ``` | [Files](https://app.codecov.io/gh/secdev/scapy/pull/4432?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev) | Coverage Δ | | |---|---|---| | [scapy/layers/smb.py](https://app.codecov.io/gh/secdev/scapy/pull/4432?src=pr&el=tree&filepath=scapy%2Flayers%2Fsmb.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev#diff-c2NhcHkvbGF5ZXJzL3NtYi5weQ==) | `76.72% <100.00%> (+0.36%)` | :arrow_up: | ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/secdev/scapy/pull/4432/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev)