Fixing connection names

secit-pl / imap-bundle

Simple php-imap integration for Symfony

MIT License

67 stars 19 forks source link

Fixing connection names #38

Closed ThomasLandauer closed 6 months ago

ThomasLandauer commented 7 months ago

This is my answer to point 1 at https://github.com/secit-pl/imap-bundle/pull/37#issuecomment-1905650091

You shouldn't call it "example_connection", cause then it would be injected as exampleConnectionConnection ;-)
I also changed full_config to fullConfig: In the end it will be camelCased anyway - so why not start with camelCase right away?

secit-pl commented 6 months ago

Closing PR without merge. Doc examples extra "connection" suffix fixes have been made independently of this PR. Using camelCase in configuration files conflicts with Symfony coding standards.