python3 support

[GoogleCodeExporter]

Hi, would be nice to have python3 support!

I attached a patch made with 2to3, here is the output:
RefactoringTool: Skipping implicit fixer: buffer
RefactoringTool: Skipping implicit fixer: idioms
RefactoringTool: Skipping implicit fixer: set_literal
RefactoringTool: Skipping implicit fixer: ws_comma
RefactoringTool: Refactored prettytable.py
RefactoringTool: Files that need to be modified:
RefactoringTool: prettytable.py

Original issue reported on code.google.com by victor.n...@gmail.com on 9 Nov 2010 at 8:21

Attachments:

• prettytable_py3.patch

[GoogleCodeExporter]

Original comment by luke@maurits.id.au on 9 Jul 2011 at 7:51

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

I would like to use prettytable as the default output formatter in cliff [1], 
and I am trying to include Python 3 support there. Are you planning to release 
a version of prettytable with Python 3 support?

Original comment by doug.hel...@gmail.com on 29 Apr 2012 at 11:07

[GoogleCodeExporter]

Oops, forgot the link to cliff: https://github.com/dreamhost/cliff

Original comment by doug.hel...@gmail.com on 29 Apr 2012 at 11:08

[GoogleCodeExporter]

the attached patch works fine to provide 2to3 support in setup.py

Original comment by jan.ditt...@gmail.com on 29 Apr 2012 at 11:23

Attachments:

• use2to3.diff

[GoogleCodeExporter]

Btw, I need Python3 support to package cliff for Debian :-)

Original comment by jan.ditt...@gmail.com on 29 Apr 2012 at 11:24

[GoogleCodeExporter]

Hi Doug, Jan,

Doug, I'm really pleased you'd like to use PrettyTable in Cliff, it looks like 
a really nifty system.  Jan, thanks very much for providing that simple patch.

Even though development on PrettyTable has been quiet for a while, I would 
actually like to finally do a new release soon.  I did some work in trunk maybe 
a month back closing some issues, but lost steam a bit when I realised that I 
was going to have to do a bit of a major internal restructuring in order to 
easily implement some features.  However, since there seems to be demand for it 
I may prioritise it again and try to get a new version out sometime soon (say, 
in the next week).  I'll make sure it has proper Python 3 support.  There will 
probably be some compatibility-breaking API changes (hopefully the last ones 
for a long time), so it may be wise to hold off on integrating it into Cliff if 
you've not done so already.

Original comment by luke@maurits.id.au on 29 Apr 2012 at 11:32

[GoogleCodeExporter]

Thanks for the update! I have already integrated with cliff, but don't worry 
about breaking the API. All of the code is in two small functions, so I can 
easily update them if necessary. I'm looking forward to getting the python 3 
support, so let me know if there is anything I can do to help.

Original comment by doug.hel...@gmail.com on 30 Apr 2012 at 2:43

[GoogleCodeExporter]

I really appreciate the offer of help with Py3 compatibility, Doug.  For now I 
think I'm going to have a go at doing it myself, just because it's the best way 
to force myself to learn more about Python 3 (something I've put off for far 
too long).  However, if I run into serious trouble and it looks like I won't be 
able to get things done in a reasonable time frame I will certainly ask you to 
have a look at it.

I made several commits last night and as of right now what's in trunk seems to 
work with Python 3.2 (and hence I presume earlier 3.x) *and* 2.7 and 2.6, i.e. 
the code is "version agnostic".  However, I got it that way through ad hoc 
tinkering.  I am sure there are better/more standard ways to achieve this and 
I'm going to read up on them in the coming days.  But at the very least, I am 
confident now that it won't be too hard to make the next official release of 
PrettyTable work with Python 2 and 3.

Original comment by luke@maurits.id.au on 1 May 2012 at 2:36

[GoogleCodeExporter]

Wonderful! I'll keep an eye on this ticket for updates. 

Original comment by doug.hel...@gmail.com on 1 May 2012 at 3:47

[GoogleCodeExporter]

After some reading, I actually think that the changes I've made to get version 
agnosticity so far are not all that bad.  There probably are nicer ways, but 
given that what is there right now seems to work and is not dreadful, I want to 
release 0.6 as it stands very soon, and leave better Python 3 support if any 
for 0.7 or later.  Version 0.6 is already long overdue and I don't want to put 
it off any longer for the sake of making things perfect and elegant, since this 
introduces the risk that I will get stuck/bored/busy and let things slide for 
another year!

If you could try out the code which is currently in trunk (and now also in 
tags/0.6-RC02) in Cliff, I would very much appreciate your feedback.

Original comment by luke@maurits.id.au on 2 May 2012 at 3:01

[GoogleCodeExporter]

I was finally able to run those tests today and everything seems to work fine. 
I was able to run the cliff tests and use the demo app after making some 
adjustments to the table formatter plugin to handle changes in the prettytable 
API.

Original comment by doug.hel...@gmail.com on 4 May 2012 at 5:29

[GoogleCodeExporter]

Hi Doug, thanks very much for doing your tests, I really appreciate it.  That's 
great news that everything seems to work.  I have one other person on the 
prettytable-devel list who is planning to run some tests soon, and unless he 
reports any breakage I will release 0.6 to PyPi tomorrow.

I'm going to close this ticket now, since Python 3 support seems to work fine, 
even if it's perhaps not optimal.  Anyone, do feel free to open a new ticket if 
you discover Python 3 problems in future!

Original comment by luke@maurits.id.au on 4 May 2012 at 6:16

• Changed state: Fixed

[GoogleCodeExporter]

That sounds like a good plan. Would you mind posting a note here when you do 
publish the release, in case I miss it go by in the RSS feed from PyPI? Thanks!

Original comment by doug.hel...@gmail.com on 4 May 2012 at 6:38

[GoogleCodeExporter]

Yeah, no problem, I'll do that.

Original comment by luke@maurits.id.au on 4 May 2012 at 6:39

[GoogleCodeExporter]

Hi Doug,

Python 0.6 is now up on PyPi, so you should be able to upgrade from 0.5 using 
easy_install or pip etc.  Let me know if you have any problems.

Original comment by luke@maurits.id.au on 6 May 2012 at 7:39

[GoogleCodeExporter]

Excellent, thanks! I have updated the dependencies of the development version 
of cliff.

Original comment by doug.hel...@gmail.com on 6 May 2012 at 6:41