search

second-state / WasmEdge-WASINN-examples

Apache License 2.0
217 stars 35 forks source link

[Docs] ggml: update README for llava #104

Closed dm4 closed 2 months ago

juntao commented 2 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit f0ee7b8207a23c845b1f6c94699e99873db7c3cc

Key Changes:

  1. The README file for the "llava" model in the "wasmedge-ggml" repository has been updated.
  2. Added instructions to download both the llava v1.5 and v1.6 models.
  3. Added a note about expected warnings when using llava v1.5 models.

Potential Problems:

  1. In the added instructions for downloading the llava v1.6 model, the URLs provided are not consistent with the previously established pattern. It should use consistent naming conventions to avoid confusion.
  2. The note about warnings when using llava v1.5 models should be elaborated on. Users might not understand the significance or implications of these warnings, and additional context would be helpful.
  3. It would be beneficial to include more details or examples regarding the "Execute the WASM with the wasmedge using the named model feature" step to provide better guidance for users.

Overall, the changes provide valuable information for users, but addressing the potential problems could enhance clarity and usability.