search

second-state / WasmEdge-WASINN-examples

Apache License 2.0
217 stars 35 forks source link

[CI] enable ggml b2534 #122

Closed hydai closed 1 month ago

juntao commented 1 month ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit c8bb41159d1751a50cb011b642ffa8b1e7dba0ee

Key changes:

  1. The patch enables the wasi_nn-ggml-b2534 plugin in the llama.yml workflow file.
  2. The insertion of wasi_nn-ggml-b2534 in the plugin array in the matrix strategy.

Potential problems:

  1. Ensure that enabling the wasi_nn-ggml-b2534 plugin does not introduce any conflicts or issues with the existing setup.
  2. Verify that the new plugin version is compatible with the current configurations and dependencies.
  3. Consider updating documentation or notifying team members about this change for awareness and potential adjustments.

Overall, the changes seem straightforward, but it's essential to validate the impact of enabling the new plugin version thoroughly.