search

second-state / WasmEdge-WASINN-examples

Apache License 2.0
217 stars 36 forks source link

Update openvino workflows #30

Closed apepkuss closed 8 months ago

apepkuss commented 8 months ago

In this PR, the build_openvino_mobilenet and build_openvino_road_seg_adas workflows are updated to use WasmEdge 0.13.4. In addition, the install_openvino script is improved.

juntao commented 8 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Summary:

The patch includes updates to the installation script for OpenVINO and the workflows. The key changes involve updating the OpenVINO version and modifying the PATH environment variable.

There are several potential problems identified in the patch. Firstly, there is no error handling or validation for the wget command used for downloading the GPG key file. This may lead to undetected issues during the download process. Secondly, there is no check or handling for the success of the "apt-key add" command, which may cause problems if the GPG key is not added successfully. Additionally, there is no verification step for the success of the "apt update" command, potentially leading to issues with package repository updates. Finally, there is no explanation provided for why the PATH environment variable is modified to include "/usr/lib/x86_64-linux-gnu", which should be clarified.

Two important findings in the patch are the removal of OPENVINO_VERSION and OPENVINO_YEAR variables from the "Install OpenVINO" step, with no clear explanation provided. This may require further investigation. Additionally, the updated VERSION environment variable in the "Install WasmEdge with Wasi-NN OpenVINO plugin" step should be evaluated for compatibility and any potential breaking changes.

In summary, it is recommended to address the potential problems identified, provide clarification on the reasons for the changes, and ensure compatibility and stability in the updated workflow.

Details

Commit 83f3f2a666f53e31cbf010907df7231b8224a52a

Key changes in the patch:

  1. The installation script for OpenVINO has been updated to use version 2023.0.2 instead of 2023.0.0.
  2. The PATH environment variable is updated to include "/usr/lib/x86_64-linux-gnu".

Potential problems:

  1. The patch does not include any error handling or validation for the wget command. If there is an issue with downloading the GPG key file, it may not be detected or handled properly.
  2. There is no check or handling for the success of the "apt-key add" command. If the GPG key is not added successfully, it may cause issues during the subsequent "apt update" command.
  3. There is no verification step for the success of the "apt update" command. If the package repositories are not updated properly, it may lead to issues during the installation of openvino.
  4. It is unclear why the PATH environment variable is modified to include "/usr/lib/x86_64-linux-gnu" at the end of the installation script. It would be helpful to provide a comment explaining the reason for this change.

These are the most important findings in the patch. It is recommended to address the potential problems mentioned above to ensure a smooth and reliable installation process for OpenVINO.

Commit 8cb98bf3618f76ecc22b543c7df73d6b9460765d

Key Changes:

Potential Problems:

Overall, further clarification is needed on the reasons for the changes and any potential impact they may have on the project.

apepkuss commented 8 months ago

@q82419 Could you please help review this PR? Thanks a lot!