second-state / WasmEdge-WASINN-examples

Apache License 2.0
217 stars 36 forks source link

[Example] Add llama streaming example #49

Closed dm4 closed 7 months ago

dm4 commented 7 months ago
juntao commented 7 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary: The pull request adds a new example for llama streaming using WASI-NN and GGML as the backend. However, there are some potential issues and errors that need to be addressed. The instructions provided in the README.md file may be missing some steps or additional dependencies/setup instructions. The code in the main.rs file also seems to be incomplete, as it is cut off at the end. Additionally, there is a change in the --nn-preload flag where the architecture value is changed from CPU to AUTO without clear justification. The commit message should provide more context on the reason for this change and its impact.

Important Findings:

Details

Commit 858fc0ce7835206d0c9dbaaa7e1639d87534a38c

Key changes:

Potential problems:

Overall, the changes seem to add a new example for llama streaming using WASI-NN and GGML as the backend. However, further review is needed to ensure the completeness and correctness of the additions.

Commit 0a89c8c3b7e32e4e2ed2fc31b2fde2d6f0665d75

Key changes:

Potential problems:

hydai commented 7 months ago

This is replaced by #52