Closed hydai closed 3 months ago
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.
Summary of key changes:
Cargo.toml
, README.md
, and src/main.rs
.wasmedge-ggml-llama-embedding
.Cargo.toml
, including serde_json
and wasi-nn
with a specified branch.wasmedge-ggml-llama-embedding
which contains the new files.Potential problems:
wasmedge-ggml-llama-embedding.wasm
and llama-2-7b-chat.Q5_K_M.gguf
) without any explanation of how they are used or where they come from. This could be a violation of licensing or intellectual property rules.$HOME/.zshenv
and $HOME/.bashrc
) which may not be portable across different environments.Overall, the patch lacks important context, documentation, and testing, and may have potential issues with portability, licensing, and error handling. It would be beneficial to address these concerns before merging the pull request.
Related: https://github.com/WasmEdge/WasmEdge/pull/3189