Merge dev branch to master - Githubissues

second-state / WasmEdge-WASINN-examples

Apache License 2.0

217 stars 35 forks source link

Merge dev branch to master #93

Closed dm4 closed 3 months ago

juntao commented 3 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit 76a06498ddcbbdd8dfdb12d359ea3741f85f6511

Key changes:

Added a new example for embedding support in ggml.
Added Cargo.toml file for dependencies.
Added README.md file with instructions on how to install WasmEdge and WASI-NN ggml plugin, prepare the WASM application, and execute it.
Added main.rs file with the implementation of the example.

Potential problems:

There is no documentation or comments in the code, making it difficult to understand the implementation.
The code could benefit from more error handling.