search

second-state / WasmEdge-go

The GO language SDK and API for WasmEdge
https://www.secondstate.io/articles/extend-golang-app-with-webassembly-rust/
Apache License 2.0
107 stars 16 forks source link

fix ast ListImports() and ListExports() panic with nil pointer #38

Closed loredanacirstea closed 1 year ago

loredanacirstea commented 1 year ago

closes https://github.com/second-state/WasmEdge-go/issues/37

alabulei1 commented 1 year ago

@q82419 Could you please take a look?

loredanacirstea commented 1 year ago

I can also add a test with a simple wasm module. Let me know.

loredanacirstea commented 1 year ago

Most tests pass, but I see the wasmedge-go-examples/go_Mobilenet test fails with segmentation violation, when registering a Tensorflow module. I did not yet have time to run the test myself (tensorflow plugin does not yet work on macos arm), but at first glance, I could not see why the changes from this PR would be the cause of this failure.

Do you think this PR is the problem?

q82419 commented 1 year ago

Most tests pass, but I see the wasmedge-go-examples/go_Mobilenet test fails with segmentation violation, when registering a Tensorflow module. I did not yet have time to run the test myself (tensorflow plugin does not yet work on macos arm), but at first glance, I could not see why the changes from this PR would be the cause of this failure.

Do you think this PR is the problem?

Sorry that I'll check this in these days.

q82419 commented 1 year ago

Most tests pass, but I see the wasmedge-go-examples/go_Mobilenet test fails with segmentation violation, when registering a Tensorflow module. I did not yet have time to run the test myself (tensorflow plugin does not yet work on macos arm), but at first glance, I could not see why the changes from this PR would be the cause of this failure.

Do you think this PR is the problem?

This seems like the ubuntu20.04 version of WasmEdge is not compatible with manylinux2014_x86_64 version of WasmEdge-TensorFlow extensions.

Use the installer with --dist manylinux2014 args will fix this. For this issue, we'll discuss and make a better solution in the future.