Closed hydai closed 1 year ago
This DNS_SERVER is not read by the Rust code. It is a built-in feature for WasmEdge socket? The socket library automatically uses it for DNS if it is set?
And also why 127.0.0.11? It is a special value defined by Docker Compose?
This DNS_SERVER is not read by the Rust code. It is a built-in feature for WasmEdge socket? The socket library automatically uses it for DNS if it is set?
Please refer to https://github.com/second-state/wasmedge_wasi_socket/pull/84/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R372
The built-in-dns
feature in wasmedge_wasi_socket will try to use 8.8.8.8:53
if the DNS_SERVER
is not set. However, docker-compose uses 127.0.0.11:53
as the nameserver.
Since we already bumped the tokio_wasi and hyper_wasi to use the built-in-dns
, this is the workaround for making it use the correct DNS nameserver unless we release new releases by turning off the built-in-dns
feature.
Ok. We should probably turn it on only if the DNS_SERVER is set.
I will merge this now.
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.
Commit 7d23faf8967ab5ab9944d00f83811ee6efd544ad
Summary of key changes:
DNS_SERVER
environment variable with the value127.0.0.11:53
to theservices
section ofdocker-compose.yml
.Potential problems:
127.0.0.11:53
or what impact it may have on the application.Note: The provided patch only includes changes to
docker-compose.yml
and does not show the complete context of the code changes.