search

second-state / wasmedge-quickjs

A high-performance, secure, extensible, and OCI-complaint JavaScript runtime for WasmEdge.
Apache License 2.0
477 stars 59 forks source link

Update QuickJS to latest, major bugs #125

Open lastmjs opened 7 months ago

lastmjs commented 7 months ago

From our project's property testing we have recently found two major bugs in QuickJS that have since been fixed.

JSON.parse bug: https://github.com/bellard/quickjs/issues/206 BigUint64Array bug: https://github.com/bellard/quickjs/issues/202

Could we get wasmedge-quickjs to update to the absolute latest QuickJS version? Now that we're using wasmedge-quickjs we would like to be on the latest QuickJS, and we have to compile our own custom QuickJS from https://github.com/second-state/quickjs-wasi/tree/master because we can't have SIMD support.

L-jasmine commented 7 months ago

Ok, I will update https://github.com/second-state/quickjs-wasi. How do you disable SIMD when build quickjs-wasi?

lastmjs commented 7 months ago

To disable I just remove the first option from here and run the file: https://github.com/second-state/quickjs-wasi/blob/master/lib/build_lib.sh#L2

L-jasmine commented 7 months ago

@lastmjs https://github.com/second-state/quickjs-wasi/pull/5 quickjs-wasi has been updated. But, you need to clone the master branch of wasi-libc as the sys-root to compile successfully.