Closed subbu963 closed 3 months ago
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.
Overall Summary:
The Pull Request introduces support for custom SSL certificates through various key changes, such as adding scripts and modules, updating dependencies, and creating new files. Potential issues include the lack of error handling in certain parts of the code, the impact of dependency updates on compatibility, and assumptions made about the success of certificate operations. Additionally, the removal of test files raises concerns about test coverage and the need to ensure thorough testing of custom SSL certificate functionality post-removal.
Key Findings:
get_cert.sh
, certs.rs
, and mod.rs
.rustls-pemfile
.Key Changes:
get_cert.sh
to retrieve combined TLS certificates for a given domain.certs.rs
for loading certificates from environment variable SSL_CERT_FILE
.mod.rs
file to load custom certificates if available, or fallback to default webpki
certificates.rustls-pemfile
version) in Cargo.lock
and Cargo.toml
.get_cert.sh
, certs.rs
, custom-ssl.js
, test-cert.rs
).Potential Problems:
get_cert.sh
might need error handling for cases where the domain argument is missing or invalid.certs.rs
file, handling Err
with io::Result::Err
could be improved for better error reporting.rustls-pemfile
is a new dependency, its usage and compatibility with existing code should be thoroughly tested.root_store.add(&cert).unwrap()
call in mod.rs
assumes that adding a certificate will always succeed, which may not always be the case. Error handling should be improved here.Overall, the addition of custom SSL certificate support is a significant enhancement, but the error handling, compatibility testing, and robustness of the new implementation should be carefully reviewed before merging.
Key Changes:
Potential Problems:
Key changes in the patch:
Potential problems:
@juntao @L-jasmine please check this
LGTM. @subbu963 Thank you so much for your pr.
wasmedge-quickjs doesnt support custom SSL support. Currently, wasmedge-quickjs uses
webpki_roots
to inject commonly used ssl certs without a way to customize. Without this PR, you cant call any HTTPS endpoints which has a cert that isnt supported bywebpki_roots
crate. Particulary, its important for companies with custom SSL certs.