Missing type attributes in template manifest are not reported to user

secondfiddle / pep-tools

PEP Tools: PDE/Eclipse Productivity

https://www.secondfiddle.org.uk/pep-tools/

Eclipse Public License 1.0

3 stars 0 forks source link

Missing type attributes in template manifest are not reported to user #12

Open fiveop opened 7 years ago

fiveop commented 7 years ago

Given a manifest file ending with

...
Name: test
Label: Test

and everything else in order, the user sees the tempalte in the New Project wizard, but the 'Next' button does not do anything visible. Rather, an NPE is thrown as can be seen in the Error Log view.

I stumbled upon this, because the last line of a manifest file does not seem to be parsed:

...
Name: test\n
Label: Test\n
Type: String

causes the error, while

...
Name: test\n
Label: Test\n
Type: String\n

does not.

edscadding commented 7 years ago

Thanks for the report – I'll have a look. As far as I remember, java.util.jar.Manifest is used for parsing, but hopefully an improvement can be made anyway.