secondlife / jira-archive

2 stars 0 forks source link

[BUG-10797] Texture uploads alter colors with sRBG color profile #1091

Open sl-service-account opened 8 years ago

sl-service-account commented 8 years ago

Steps to Reproduce

Uploading a clothing texture.

Actual Behavior

A texture uploaded on OS X has the colors altered to be a bit darker and more contrast than the source textures. Textures uploaded on Windows and Linux do not show this effect.

Expected Behavior

The texture's colors should be unaltered by the upload.

Other information

On the attached snapshot, the texture on the left was uploaded from OS X, on the right from Windows. The attached PNG file was used to upload both textures.

This was originally discovered on Firestorm, and is also reported on the Firestorm JIRA as http://jira.phoenixviewer.com/browse/FIRE-17385 .

Attachments

Links

Related

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-10797 | | Summary | Texture uploads alter colors with sRBG color profile | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Reporter | Tonya Souther (tonya.souther) | | Created at | 2015-11-27T01:08:24Z | | Updated at | 2017-12-14T18:25:43Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2015-12-02T12:07:28.545-0600', "Is there anything you'd like to add?": 'On the attached snapshot, the texture on the left was uploaded from OS X, on the right from Windows. The attached PNG file was used to upload both textures.\r\n\r\nThis was originally discovered on Firestorm, and is also reported on the Firestorm JIRA as http://jira.phoenixviewer.com/browse/FIRE-17385 .', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': 'A texture uploaded on OS X has the colors altered to be a bit darker and more contrast than the source textures. Textures uploaded on Windows and Linux do not show this effect.', 'What were you doing when it happened?': 'Uploading a clothing texture.', 'What were you expecting to happen instead?': "The texture's colors should be unaltered by the upload.", } ```
sl-service-account commented 8 years ago

Kyle Linden commented at 2015-12-02T18:07:29Z

Hello Tonya,

Will you please provide the full Help > About Second Life information for the Windows and Linux systems referenced in this report.

Thank you

sl-service-account commented 8 years ago

Tonya Souther commented at 2015-12-02T18:54:54Z

I didn't do the Windows upload, as I don't run SL on Windows. I'll ask Whirly Fizzle, who ran the test there, to comment with her system information. The Linux upload was done with Firestorm for Linux; I can't get the LL viewer to run on my Linux system. The Linux OS itself is Linux Mint 17.1 with all current updates applied. Here's the Help->About from that:

Firestorm 4.7.6 (48129) Nov 28 2015 12:42:45 (Firestorm-private-dot) with OpenSimulator support Release Notes

You are at 103.0, 26.0, 25.9 in Catalina located at sim8876.agni.lindenlab.com (216.82.41.52:13015) SLURL: http://maps.secondlife.com/secondlife/Catalina/103/26/26 (global coordinates 172647.0, 236826.0, 25.9) Second Life Server 15.11.13.307797 Release Notes

CPU: AMD A10-5800K APU with Radeon(tm) HD Graphics (2900 MHz) Memory: 15951 MB OS Version: Linux 3.13.0-37-generic #64-Ubuntu SMP Mon Sep 22 21:28:38 UTC 2014 x86_64 Graphics Card Vendor: NVIDIA Corporation Graphics Card: GeForce GTX 570/PCIe/SSE2

OpenGL Version: 4.4.0 NVIDIA 340.96

RestrainedLove API: RLV v2.8.0 / RLVa v1.4.10a libcurl Version: libcurl/7.38.0 OpenSSL/1.0.1i zlib/1.2.8 J2C Decoder Version: KDU v7.7.1 Audio Driver Version: FMOD Ex 4.44.56 Qt Webkit Version: 4.7.1 (version number hard-coded) Voice Server Version: Not Connected Settings mode: Firestorm Viewer Skin: Firestorm (Grey) Font Used: Roboto (96 dpi) Font Size Adjustment: 0 pt UI Scaling: 1 Draw distance: 128 m Bandwidth: 500 kbit/s LOD factor: 2 Render quality: High-Ultra (6/7) Advanced Lighting Model: Yes Texture memory: 512 MB (1) VFS (cache) creation time (UTC): 2015-3-12T21:11:6 Built with GCC version 40804 Packets Lost: 0/656 (0.0%)

sl-service-account commented 8 years ago

Tonya Souther commented at 2015-12-02T19:16:36Z, updated at 2015-12-02T19:17:34Z

Ah, the LL viewer once again runs on my Linux box. I just repeated the test there with it, and got the same results as I had from Firestorm.

Second Life 3.8.6 (305981) Oct 14 2015 00:14:33 (Second Life Release) Release Notes

You are at 155.7, 243.3, 3501.3 in Raindown located at sim10229.agni.lindenlab.com (216.82.49.151:13012) SLURL: http://maps.secondlife.com/secondlife/Raindown/156/243/3501 (global coordinates 464028.0, 305139.0, 3501.3) Second Life RC BlueSteel 15.11.13.307797 Retrieving...

CPU: AMD A10-5800K APU with Radeon(tm) HD Graphics (2900 MHz) Memory: 15951 MB OS Version: Linux 3.13.0-37-generic #64-Ubuntu SMP Mon Sep 22 21:28:38 UTC 2014 x86_64 Graphics Card Vendor: NVIDIA Corporation Graphics Card: GeForce GTX 570/PCIe/SSE2

OpenGL Version: 4.4.0 NVIDIA 340.96

libcurl Version: libcurl/7.38.0 OpenSSL/1.0.1h zlib/1.2.8 J2C Decoder Version: KDU v7.2 Audio Driver Version: (none) Qt Webkit Version: 4.7.1 (version number hard-coded) Voice Server Version: Vivox

Built with GCC version 40603 Packets Lost: 0/8829 (0.0%)

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-12-02T19:38:56Z

I uploaded the textures for Tonya on Windows to compare. Here is my system:

Second Life 3.8.7 (308081) Nov 19 2015 13:26:33 (Second Life Release)
Release Notes

You are at 92.5, 125.6, 21.2 in Testylvania Sandbox located at sim8922.agni.lindenlab.com (216.82.41.98:12035)
SLURL: http://maps.secondlife.com/secondlife/Testylvania%20Sandbox/93/126/21
(global coordinates 332,637.0, 306,302.0, 21.2)
Second Life Server 15.11.13.307797
Release Notes

CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (3491.95 MHz)
Memory: 16268 MB
OS Version: Microsoft Windows 7 64-bit Service Pack 1 (Build 7601)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: GeForce GTX 750/PCIe/SSE2

Windows Graphics Driver Version: 10.18.0013.5900
OpenGL Version: 4.5.0 NVIDIA 359.00

libcurl Version: libcurl/7.38.0 OpenSSL/1.0.1h zlib/1.2.8
J2C Decoder Version: KDU v7.2
Audio Driver Version: FMOD Ex 4.44.31
Qt Webkit Version: 4.7.1 (version number hard-coded)
Voice Server Version: Vivox 4.6.0017.21209

Built with MSVC version 1800
Packets Lost: 41/93,851 (0.0%)

I'm going to add more information about this issue shortly - I need to get some snapshots...

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-12-02T20:01:49Z, updated at 2015-12-02T20:03:51Z

sl-service-account commented 8 years ago

Tonya Souther commented at 2015-12-03T02:59:44Z

Note that using "Show color under cursor" in the lower right corner of the texture, away from the latex highlighting, should show the color as RGB (244,117,1).

I wonder if setting the texture to Apple RGB and then uploading on OS X will cause it to go correctly...have to try it.

sl-service-account commented 8 years ago

Tonya Souther commented at 2015-12-03T03:11:33Z, updated at 2015-12-03T03:11:56Z

Only PNGs saved from Photoshop documents set to sRGB have this issue. Setting the PSD to Apple RGB, or saving to TGA instead of PNG, makes the color upload correctly.

This says that the viewer is treating the file as Apple RGB incorrectly when it is really sRGB. Perhaps it should detect the issue and shift to the proper profile?

I know I've looked at that general area before, and color management makes my head hurt.

sl-service-account commented 8 years ago

Tonya Souther commented at 2015-12-07T20:12:49Z

The revised summary isn't quite correct: Apple RGB PNGs upload correctly, but sRGB ones don't.

sl-service-account commented 8 years ago

Tonya Souther commented at 2015-12-08T06:24:16Z

It's probably worth testing other color profiles, too, besides those two to make sure they work - or fail int he same way.