Open sl-service-account opened 11 years ago
sl-service-account
commented
11 years ago MartinRJ Fayray commented at 2012-09-30T04:20:43Z, updated at 2012-09-30T04:38:33Z
Hi Whirly, I cannot reproduce the above example.
Do I need to edit floater_tools.xml for the example above, too? ETA: Second Life 3.4.0 (264911) Sep 19 2012 11:15:02 (Second Life Release)
sl-service-account
commented
11 years ago Whirly Fizzle commented at 2012-09-30T04:39:28Z
No, no edit needed for the given example, the error is large enough to show (1.999 instead of 2.000)
sl-service-account
commented
11 years ago Whirly Fizzle commented at 2012-09-30T04:47:37Z, updated at 2012-09-30T05:32:50Z
Its actually easy to repro, just difficult to explain how to repro :D
Extra info on the Firestorm JIRA here: http://jira.phoenixviewer.com/browse/FIRE-7801
Phoenix viewer JIRA here: http://jira.phoenixviewer.com/browse/PHOE-3650
Siana from Singulatity viewer verified this bug affects her mesh enabled versions of the viewer but not her pre mesh versions. Premesh Phoenix does not have this bug, Mesh backported Phoenix has the bug Premesh Firestorm does not have this bug, Mesh Firestorm has the bug 1.23 and Snowglobe verified to not have the bug.
I was using the Second Life 3.4.0 (264911) release to repro while writing this.
sl-service-account
commented
11 years ago MartinRJ Fayray commented at 2012-09-30T04:48:02Z, updated at 2012-09-30T04:53:08Z
I've edited my above comment and attached a screenshot. I even tortured my prim even more and was not able to repro this. ETA: Let me try again= ) Could you point me out where I must change floater_tools.xml to display more than 3 digits. I suspect (since I cannot find the value "3" in that file, excepts for the 'features' tab), that this change to 5 digits is not done via xml but it's a change in the edit floater code, instead. I'm not totally sure, though!
sl-service-account
commented
11 years ago Whirly Fizzle commented at 2012-09-30T04:56:18Z
headesk just noticed an error in my repro, edited.
sl-service-account
commented
11 years ago MartinRJ Fayray commented at 2012-09-30T04:57:12Z
Indeed, when I torture my prim to the extreme, I can reproduce the bug! Thanks for pointing that out, Whirly! :)
sl-service-account
commented
11 years ago Whirly Fizzle commented at 2012-09-30T04:58:36Z
Yay! Got there in the end. We have all been banging out heads on this one today too :D
Now, try the same on good ol Snowglobe for example and you will see the bug doesnt reproduce.
sl-service-account
commented
11 years ago Whirly Fizzle commented at 2012-09-30T05:21:01Z
Could you point me out where I must change floater_tools.xml to display more than 3 digits
Using Second Life 3.4.0 (264911) release floater_tools.xml
Line 2810...
<spinner follows="left|top" height="19" initial_value="0" label="Horizontal (U)"
add in decimal_digits="5"
so that block becomes
<spinner decimal_digits="5" follows="left|top" height="19" initial_value="0" label="Horizontal (U)"
Do the same after line 2830 for vertical
Now you will see using my repro example above that the repeats actually change to 1.99982 ;)
sl-service-account
commented
11 years ago MartinRJ Fayray commented at 2012-09-30T05:37:25Z
Thank you, that works!
This bug reproduces on all mesh enabled viewers, the official Viewer 3 and TPV viewers that are mesh enabled, both V1 based and V3 based.
It does not reproduce on any pre mesh viewer, both V3 based or V1 based, including 1.23, Snowglobe, premesh official Viewer 2/3 versions or any pre mesh TPV.
h4.Steps To Reproduce
Take some valium, you're going to need it.
Rez a prim and name it Prim A
Rez another prim next to Prim A and name it Prim B
Plop a texture grid onto the upper faces of both prims (not essential to repro but helps to see whats happening as you follow the steps). A suitable texture is attached to this issue.
Arrange Prim A and Prim B like so...
Edit on Prim A -> Enable Select face -> Click top face of prim A -> Select Planar mapping under the texture tab
Click top face of Prim B -> Select Planar mapping under the texture tab
With the top face of Prim B still selected, hold SHIFT and click on top face of Prim A so both faces are selected
Tick "Align planar faces" and observe that now Prim B's texture will be aligned according to Prim A's.
With both prims as regular default cubes, all parameters get set properly - examining the cubes at the moment will show you the expected behaviour.
Observe that the horizontal and vertical "Repeats Per Meter" parameters on both prims' top faces should be 2.000 (make sure select face is enabled and click on each prims upper face in turn)
Adding a deformity to one of the prims will reproduce the bug. So we will use Pathcut as an example...
Edit on Prim B and add a pathcut of B: 0.025 E: 1.000
Make sure select face is enabled in build floater
Select top face of Prim B, hold SHIFT and click on top face of Prim A so both faces are selected and tick "Align planar faces"
h4.Observed Behaviour
Examine the top face of Prim B (Enable select face and click top face on Prim B) and observe that the horizontal and vertical repeats per meter are now 1.999
h4.Expected Behaviour
Horizontal and vertical repeats per meter should be 2.000 as exhibited on the top face of prim A
h4.Other Information
To quote one of our Firestorm devs: "If that's float errors creeping up, it will be a world of hurt" :D
The misalignment value seems to vary depending on what modifications are made to the default cube shape.
If both prims have the exact same Path Cut, the alignment works just fine.
This difference in repeats per meter might sound like an insignificant value but it adds up and causes texture alignment issues where the textures don't match because of the minute difference, causes texture flicker and drives builders crazy.
If you repeat the same steps on a version of Viewer 3 before mesh was added, the old SL 1.23 viewer, Snowglobe 1.4.2.3626 etc you will not see this bug. Repeating the above steps on Snowglobe will display the repeats per meter on the pathcut cube as 2.000
Viewer 3 only displays 3 decimal places for horizontal/vertical repeats per meter, so note that some deforms of the cube may look like they give no error, but there is one and can easily be seen by a simple edit to floater_tools.xml to increase decimal places displayed to 5.
Attachments
Original Jira Fields
| Field | Value | | ------------- | ------------- | | Issue | BUG-255 | | Summary | Align Planar Faces function is misaligning textures ONLY on mesh enabled viewers | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Released | | Reporter | Whirly Fizzle (whirly.fizzle) | | Created at | 2012-09-30T01:34:31Z | | Updated at | 2014-03-10T21:29:16Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2012-09-29T23:20:43.019-0500', "Is there anything you'd like to add?": 'my brain hurts', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': 'will fill in soon...', 'What were you doing when it happened?': 'Please can someone fix this form.....', 'What were you expecting to happen instead?': 'a', } ```