[BUG-1098] Region Windlight - Fixed Sky Cloud Coverage reverts to 0.27 when toggling view back to region sky

[sl-service-account]

When a fixed sky is set in region estate, Cloud Coverage will reset to 0.27 if you choose a different windlight sky then switch back to the estate fixed sky.

Steps To Reproduce

1. Firstly create a new windlight sky with high cloud coverage in order to easily see the bug

   • World -> Environment Editor -> Sky Preset -> New Preset
   • Name this preset BUG-1098 test
   • On Cloud tab set Cloud Coverage to 0.75
   • Tick "Make this preset my new sky setting" -> Save
   • Observe you will see a nice overcast sky with heavy clouds like so:

   

   2. Go to World -> Region/Estate -> Environment -> Choose "Fixed Sky" -> Pick "BUG-1098 test" from the dropdown -> Apply

   Observe sky still looks the same

   3. Go to World -> Sun -> Midday

   Observe sky changes to Midday - which is expected

   4. Go to World -> Sun -> Use Region Settings

   Observed Behaviour

• Sky is now a mostly black with minimal cloud coverage like so:

  

• To verify that Cloud Coverage has indeed reset itself to exactly 0.27, create a new sky preset, which will use the current sky as a base...

  • World -> Environment Editor -> Sky Settings -> New Preset
  • Observe under clouds tab that Cloud Coverage is indeed 0.27

  Expected behaviour

  Sky should display as in the first image - with a 0.75 cloud coverage

  h4.Other Information

• After relog you will see the correct sky again until you choose a different windlight sky (eg - sunrise, sunset, midnight or midday) and then go back to using region settings

Reproduces on:

• Second Life 3.4.3 (268139) Dec 13 2012 15:46:18 (Second Life Beta Viewer)
• Second Life 3.4.2 (267137) Nov 19 2012 12:24:52 (Second Life Release)
• Current and previous Firestorm, Exodus, Catznip - I dont think this is a new bug. Possibly it has always been this way.

Links

Related

• [ ] https://github.com/secondlife/jira-archive/issues/12266

Original Jira Fields

| Field | Value | | ------------- | ------------- | | Issue | BUG-1098 | | Summary | Region Windlight - Fixed Sky Cloud Coverage reverts to 0.27 when toggling view back to region sky | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Released | | Reporter | Whirly Fizzle (whirly.fizzle) | | Created at | 2012-12-16T20:09:28Z | | Updated at | 2016-11-21T15:05:56Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2016-03-02T14:39:33.968-0600', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': 'a', 'What were you doing when it happened?': 'a', 'What were you expecting to happen instead?': 'a', } ```

[sl-service-account]

sovereign.engineer commented at 2016-03-02T20:39:34Z

Here's a fix for this: https://bitbucket.org/alchemyviewer/alchemy-dire/commits/112c0839da8032ccc12d8301745ee9e9

[sl-service-account]

AndreyK ProductEngine commented at 2016-06-27T14:58:23Z

Please open access to this commit or upload it as a patch.

[sl-service-account]

Whirly Fizzle commented at 2016-06-27T15:38:03Z

Sovereign's fix is visible here: http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/323fa27ce6d6

[sl-service-account]

AndreyK ProductEngine commented at 2016-06-27T16:14:24Z, updated at 2016-06-27T16:18:14Z

Thanks. Is Drake Arconis mentioned as autor in commit and Sovereign Engineer a same person?

[sl-service-account]

Whirly Fizzle commented at 2016-06-27T16:37:27Z

Yes, same person.

[sl-service-account]

AndreyK ProductEngine commented at 2016-06-27T16:47:52Z, updated at 2016-06-27T16:50:22Z

Thanks. Needed that for 'contributions' list.

[sl-service-account]

Whirly Fizzle commented at 2016-10-29T16:00:04Z

@AndreyK This fix was backed out in the latest Maint-RC viewer: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/4.1.2.321183

This has caused BUG-1098 and VWR-27052 to reproduce again.

Is there any chance BUG-1098 and VWR-27052 can be finally fixed? I'm seeing broken skies everywhere again.

Example:

• Clouds rendering correctly on the previous Maint-RC: http://prnt.sc/d0hgyl
• Clouds broken again on latest Maint-RC: http://prnt.sc/d0hdog

I know the fix was backed out because it caused the jumpy clouds bug - BUG-40617 But the affected day cycles were broken anyway - those day cycles swap between different windlight sky presets that don't maintain a consistent cloud direction or coverage between them.

Now the fix is backed out all windlight skies are rendering incorrectly & showing incorrect cloud coverage.

[sl-service-account]

AndreyK ProductEngine commented at 2016-10-30T20:35:46Z, updated at 2016-10-30T20:40:47Z

Is there any chance BUG-1098 and VWR-27052 can be finally fixed? Unfortunately nobody is working at it at the moment.

But the affected day cycles were broken anyway - those day cycles swap between different windlight sky presets that don't maintain a consistent cloud direction or coverage between them. If day cycles got broken not by this fix, then there is a chance fix will be reapplied, I will discuss it with whoever was fixing BUG-40617. Can you provide a scenario for this case?

[sl-service-account]

AndreyK ProductEngine commented at 2016-11-18T22:53:23Z

@Whirly Please check this build, for me it reverts setting fine and doesn't cause BAG-40617. http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/maint-neko/rev/321770/index.html Note: It probably requires some modifications to ignore regions set to "day cycles" and some cases of "default" initialization, but so far can't detect any issues, so it also might go as it is.

[sl-service-account]

Whirly Fizzle commented at 2016-11-19T18:54:04Z

Thanks!

On the test build Second Life 4.1.3.321770 (Second Life Test).

• BUG-1098 (this bug) is fixed \o/.
• BUG-40617 does not reproduce \o/.

As far as I can see, all the windlight skies & day cycles I tested are behaving correctly on the test build :)

[sl-service-account]

AndreyK ProductEngine commented at 2016-11-21T15:05:57Z

Thanks, fix at review.