search

secondlife / jira-archive

3 stars 0 forks source link

[BUG-5550] Instant message toasts and certain kinds of popups (ex. group invites) fail to display if an offline inventory offer was received before logging in #13515

Open sl-service-account opened 10 years ago

sl-service-account commented 10 years ago

Steps to Reproduce

1.) Log into SL with your avatar.

2.) Ensure that in chat preferences for your viewer, that "pop up the message" is selected for all conversation types as it is by default in a new install of the viewer.

2.) Open an IM session to an alternate avatar of your choosing while the alternate avatar is offline.

3.) Open your inventory and go to your Objects folder and find a transferable item to offer to your alternate avatar.

4.) Drag and drop the object you have selected into the IM session window for your alternate avatar and confirm to send.

5.) Log out of SL.

6.) Log into SL with your alternate avatar that you sent the item to previously. It does not matter if you press Show or Discard for the inventory item that you received from your other avatar in the IM window or even ignore dealing with the offer in any way whatsoever. The result to come will be the same.

7.) Start conversations with people you know, join group chats, or wait for yourself to be messaged by people.

8.) Find an object inworld or rez one yourself that offers you an inventory item when you click it. Click the item. Press accept for the inventory offer.

9.) Repeat step 8, but press deny this time for the inventory offer.

10.) Ask someone you know or log in another alternate avatar simultaneously to have a group invite for a group you do not belong to sent to you.

Actual Behavior

The chat toasts that should be visible in the upper right hand corner of the screen for conversations that are not selected or not in focus are not visible.

There are no toasts giving details about the accept or deny action after you press accept or deny for the inventory offer from the object you clicked on.

When receiving the group invite, it is not visible on your screen and it is automatically collapsed into the envelope before you can see it.

Expected Behavior

Chat toasts should be visible in the upper right hand corner of the screen.

Toasts that give details about the accept or deny action after you accept or deny an inventory offer should be visible in the upper right hand corner of the screen.

Group invites should be visible when they are received in the upper right hand corner of the screen for the normal duration time before being collapsed into the envelope.

Other information

This problem did not happen on version 3.7.2 and earlier. The problem began with 3.7.3 and continues to happen with 3.7.4

I found the changeset in viewer-release that was committed between version 3.7.2 and 3.7.3 that i believe to be the cause of this problem.

MaksymS ProductEngine - MAINT-3536 FIXED new crash in XML_ParserFree: temporary solution http://hg.secondlife.com/viewer-release/commits/f7234f8fdce8a51345aea05da8e531839344ec4a

Attachments

Links

Duplicates

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-5550 | | Summary | Instant message toasts and certain kinds of popups (ex. group invites) fail to display if an offline inventory offer was received before logging in | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Reporter | Gibson Firehawk (gibson.firehawk) | | Created at | 2014-03-28T19:15:54Z | | Updated at | 2014-05-26T22:40:00Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2014-03-28T16:29:56.785-0500', 'Regression?': ['Issue is a Regression'], 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': 'In about 1 out of 3 sessions of SL and at random, when receiving either instant messages or group messages, the toasts that should be appearing in the upper right hand corner of the screen are never seen or shown. The problem occurs all the way from login to shutdown in one of these problematic sessions regardless of who the messages are coming from or how many conversations there are. In all cases where the toasts should be displayed, such as particular a conversation not selected and a new message arrives, or current conversation selected but focus is in on the world, or a completely new conversation is started by another person, the toasts are not displayed. The toolbar button at the bottom flashes and the line for the individual conversation flashes and a sound plays, but no toasts are visible. This problem occurs with settings for chat in preferences all left at their defaults to pop up the message for all kinds of conversations. (screenshot attached)\r\n\r\nThe problem also manifests itself with certain kinds of popups that should normally occur in the upper right hand screen where the toasts are, such as receiving group invites. In one of these sessions where toasts are also not shown in the upper right, if receiving a group invite from an object or a person, the invite is never shown on the screen but it is automatically forced into the envelope. Toasts for accepting and denying an inventory offer are also not displayed. If clicking and opening the envelope and manually selecting notifications to view, the problem vanishes and then all toasts and popups begin to work again correctly for the rest of the session. \r\n\r\nThis problem occurring in about 1 out of 3 sessions on average never happened on version 3.7.2 and earlier. It started after updating to 3.7.3 and still happens now on 3.7.4. I noticed that there was much work done between version 3.7.2 and 3.7.3 on the toast and panel system in an attempt to fix a login crash and that is where i have suspicions this bug was created. When using version 3.7.2 and older, this problem never appears. It only occurs on 3.7.3, 3.7.4, and newer.\r\n\r\nI attached a screenshot of the chat preferences panel and also have attached a copy of my secondlife.log for a session where the toasts were not visible and received an invite to a group where the invite was automatically force collapsed into the envelope. In that session i also dealt with some inventory offers and no toasts were displayed for the accept or deny of the items. I have also attached the viewer generated settings.xml files. After a relog, the toasts began to work again. They did also for the next session, then died again in the session after that.\r\n\r\nI made some test builds from viewer-bear and viewer-tiger and the problem persists in both also.\r\nSo far the only way i have found to avoid this problem until it is fixed is to go back to using 3.7.2.\r\n', 'What were you doing when it happened?': "I have not found a way to reproduce this problem 100 percent of the time yet but so far it appears to happen at least 1 out of 3 sessions of SL at random. Reinstalls of the program, clean installs (deleting the hidden settings folders manually) do not eliminate the problem. Even when doing a clean install with the settings folders having been deleted beforehand and leaving all settings at total default the problem still occurs about 1 out of 3 sessions in SL on average. Whether there are notifications saved in the envelope in the right hand corner of the screen from the previous session or empty upon login seems to make no difference either. Whether there are inventory offers waiting to be denied or accepted on login for the session also appears to make no difference.\r\n\r\nI suspect that almost anyone who frequently uses SL and pays attention to whether or not they are seeing toasts for instant messages and various things in every session will eventually notice this problem also even though a way to 100 percent reproduce hasn't been found yet by me.", 'What were you expecting to happen instead?': 'That all toasts and popups would properly display at all times in every SL session.', } ```
sl-service-account commented 10 years ago

Marissa Linden commented at 2014-03-28T21:29:57Z

I don't seem to be able to reproduce this in Windows. I wonder if it is Mac related. I'll need to test further.

sl-service-account commented 10 years ago

Gibson Firehawk commented at 2014-03-29T06:31:08Z, updated at 2014-03-29T06:46:06Z

I found the exact circumstances that cause this and updated the title and information accordingly, including steps to consistently reproduce.

I have been running a build of viewer-release with the changeset http://hg.secondlife.com/viewer-release/commits/f7234f8fdce8a51345aea05da8e531839344ec4a that i mentioned in the information backed out and have been unable to reproduce the problem again so far. Will report back again after some more extensive testing.

sl-service-account commented 10 years ago

Whirly Fizzle commented at 2014-03-29T07:42:47Z, updated at 2014-03-29T07:48:50Z

I can reproduce this on Second Life 3.7.4 (288138) Mar 15 2014 16:28:23 (Second Life Release) on Windows.

You know, I've seen this before on the Group Bans viewer when sending my alts group invites and couldnt reproduce it again after relogging.

I can reproduce everything stated in this issue apart from the inventory offer dialogs, I do see those Edit: No sorry, pebkac. I see the accept/decline inventory offer but not the "You have accepted/declined offer from..." toasts. However, I do not get any group or IM chat toasts displaying onscreen at all (despite my settings to pop up the messages), and group invites never display on the screen - they just go straight into the notifications envelope.

Good job at working out the repro for this!

My testing system:


Second Life 3.7.4 (288138) Mar 15 2014 16:28:23 (Second Life Release)
Release Notes

You are at 112.5, 90.4, 21.6 in Testylvania Sandbox located at sim9649.agni.lindenlab.com (216.82.44.106:13001)
SLURL: http://maps.secondlife.com/secondlife/Testylvania%20Sandbox/112/90/22
(global coordinates 332,656.0, 306,266.0, 21.6)
Second Life Server 14.02.28.287383
Retrieving...

CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (3491.97 MHz)
Memory: 16268 MB
OS Version: Microsoft Windows 7 64-bit Service Pack 1 (Build 7601)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: GeForce GTX 750/PCIe/SSE2

Windows Graphics Driver Version: 9.18.0013.3523
OpenGL Version: 4.4.0

libcurl Version: libcurl/7.24.0 OpenSSL/0.9.8q zlib/1.2.5
J2C Decoder Version: KDU v7.0
Audio Driver Version: FMOD Ex 4.44.31
Qt Webkit Version: 4.7.1 (version number hard-coded)
Voice Server Version: Vivox 4.5.0009.17865

Built with MSVC version 1600
Packets Lost: 7/11,576 (0.1%)
sl-service-account commented 10 years ago

Gibson Firehawk commented at 2014-03-29T07:48:03Z

The inventory offer dialogs for the user to press accept or decline show, but its the toasts the come after pressing accept or decline that are broken along with the chat toasts and the group invites.

sl-service-account commented 10 years ago

Whirly Fizzle commented at 2014-03-29T07:49:31Z

lol yes! Just edited my comment after I realised that.

sl-service-account commented 10 years ago

Gibson Firehawk commented at 2014-03-31T05:15:24Z

So i ran many, many sessions over the weekend and did a lot of testing with changeset http://hg.secondlife.com/viewer-release/commits/f7234f8fdce8a51345aea05da8e531839344ec4a backed out, and all toasts appeared normally in every session including the sessions where an inventory offer was received while offline before logging in with it backed out. I didn't see any crashes either that the changeset claims to be a temporary solution for.

sl-service-account commented 10 years ago

Marissa Linden commented at 2014-03-31T20:43:35Z

I can verify this behavior now. Thank you for the steps to reproduce Gibson.

sl-service-account commented 10 years ago

Whirly Fizzle commented at 2014-04-09T07:54:19Z

https://bitbucket.org/lindenlab/viewer-bear/commits/940b1d7072ac1b2f827082916e4bbe4077faa7d8

MAINT-3903 FIXED Instant message toasts and certain kinds of popups (ex. group invites) fail to display if an offline inventory offer was received before logging in: Backed out changeset: f7234f8fdce8: MAINT-3536 new crash in XML_ParserFree.