search

secondlife / jira-archive

2 stars 0 forks source link

[BUG-7377] "Use built-in browser for Second Life links only" matches things it should not #15102

Open sl-service-account opened 10 years ago

sl-service-account commented 10 years ago

Steps to Reproduce

chatting

Actual Behavior

With my preferences set to "Use built-in browser for Second Life links only", I clicked on the link:

http://www.google.com?lindenlab.com

and it opened the internal browser

Expected Behavior

It should have opened my external browser because the domain of the request was not in either lindenlab.com or secondlife.com

Other information

We should parse the url and match only on the domains. It should also not match anywhere... only proper subdomains, so for example lindenlab.com.example.com should not match, nor should foobar.lindenlab.comexample.com

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-7377 | | Summary | "Use built-in browser for Second Life links only" matches things it should not | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Reporter | Oz Linden (oz.linden) | | Created at | 2014-09-26T18:09:29Z | | Updated at | 2015-01-29T22:39:50Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2015-01-29T16:39:50.975-0600', "Is there anything you'd like to add?": 'We should parse the url and match only on the domains.\r\nIt should also not match anywhere... only proper subdomains, so for example lindenlab.com.example.com should not match, nor should foobar.lindenlab.comexample.com\r\n', 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': 'With my preferences set to "Use built-in browser for Second Life links only", I clicked on the link:\r\n\r\nhttp://www.google.com?lindenlab.com\r\n\r\nand it opened the internal browser', 'What were you doing when it happened?': 'chatting', 'What were you expecting to happen instead?': 'It should have opened my external browser because the domain of the request was not in either lindenlab.com or secondlife.com', 'Where': 'not relevant', } ```
sl-service-account commented 9 years ago

Whirly Fizzle commented at 2015-01-29T22:39:51Z

Fixed in the Maintenance-RC: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/3.7.25.298030 "MAINT-4497 "Use built-in browser for Second Life links only" matches things it should not"