[BUG-11460] [MAINT-RC] Viewer does not display ban lines & crashes when attempting to cross into a banned parcel

[sl-service-account]

Steps to Reproduce

• Login on the Maint-RC viewer: https://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/4.0.2.311378

• World -> Show -> Ban lines -> Tick this.

• Stand near a parcel which you are banned from & look for the ban lines. For example: http://maps.secondlife.com/secondlife/Shinmai/68/172/29 (not public access).

• Attempt to enter the banned parcel.

  Observed Behaviour

• Viewer does not render any ban lines.

• Viewer usually crashes when attempting to enter a banned parcel.

• Callstack:

  
  Operating system: Windows NT
                  6.1.7601 Service Pack 1
  CPU: x86
     GenuineIntel family 6 model 60 stepping 3
     8 CPUs
  
  Crash reason:  EXCEPTION_ACCESS_VIOLATION_EXEC
  Crash address: 0x6d617261
  Process uptime: 352 seconds
  
  Thread 0 (crashed)
  0  0x6d617261
  1  SecondLifeViewer.exe!LLViewerParcelMgr::renderCollisionSegments(unsigned char *,int,LLViewerRegion *) [llglsandbox.cpp : 644 + 0x1d]
  2  SecondLifeViewer.exe!LLViewerParcelMgr::renderParcelCollision() [llviewerparcelmgr.cpp : 878 + 0x21]
  3  SecondLifeViewer.exe!render_hud_elements() [pipeline.cpp : 4063 + 0xc]
  4  SecondLifeViewer.exe!render_ui(float,int) [llviewerdisplay.cpp : 1287 + 0x5]
  5  SecondLifeViewer.exe!display(int,float,int,int) [llviewerdisplay.cpp : 1031 + 0x13]
  6  SecondLifeViewer.exe!LLAppViewer::mainLoop() [llappviewer.cpp : 1471 + 0x1d]
  7  SecondLifeViewer.exe!WinMain [llappviewerwin32.cpp : 322 + 0x7]
  8  SecondLifeViewer.exe!__tmainCRTStartup [crtexe.c : 618 + 0xe]
  9  kernel32.dll + 0x1338a
  10  ntdll.dll + 0x39a02
  11  ntdll.dll + 0x399d5

  Expected Behaviour

  Cookies!

  Other Information

  Does not reproduce on default release Second Life 4.0.1 (310054) Jan 14 2016 18:17:17 (Second Life Release)

Attachments

• Callstack.txt 2016-02-24 23:01:34
• Logs.zip 2016-02-24 23:01:34

Links

Duplicates

• [ ] https://github.com/secondlife/jira-archive/issues/1652

Original Jira Fields

| Field | Value | | ------------- | ------------- | | Issue | BUG-11460 | | Summary | [MAINT-RC] Viewer does not display ban lines & crashes when attempting to cross into a banned parcel | | Type | Bug | | Priority | Unset | | Status | Been Triaged | | Resolution | Triaged | | Reporter | Whirly Fizzle (whirly.fizzle) | | Created at | 2016-02-25T03:46:36Z | | Updated at | 2016-03-07T21:36:52Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2016-02-25T13:06:31.511-0600', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': '...', 'What were you doing when it happened?': 'Filling in', 'What were you expecting to happen instead?': '...', } ```

[sl-service-account]

Whirly Fizzle commented at 2016-02-25T14:33:31Z

I just saw a commit pushed that looks like it may fix this crash: https://bitbucket.org/andreykproductengine/lynx-maint/commits/f37d8f257901d69890f8acb997119b22519c2881

[sl-service-account]

Grumpity Linden commented at 2016-02-25T19:06:32Z

yes! that's the hope :)

[sl-service-account]

Whirly Fizzle commented at 2016-02-26T21:48:47Z

Testing on http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-lynx/rev/311655/index.html, which includes the crash fix.

• I can no longer reproduce the crash.

• However ban lines are not rendering too well. Usual behaviour on default release: https://gyazo.com/5c0d8a725bd1f0e428ff8086a59fd267 Ban lines blink sometimes when moving camera but are always visible when your avatar is close enough.

• On the test build, Second Life 4.0.2 (311655) Ban lines are totally invisible at most camera angles. Moving camera or avatar will make the appear briefly, then they flicker & turn invisible again, even when your avatar is right up against the ban lines. https://gyazo.com/a91ab51fc6bdf50f41c136afba709317 https://gyazo.com/f57cfb997eec1f9ee09ff0b8d15a628e

Second Life 4.0.2 (311655) Feb 25 2016 08:29:58 (Second Life Release)
Release Notes

You are at 45.5, 171.3, 31.7 in Shinmai located at sim10468.agni.lindenlab.com (216.82.51.174:13000)
SLURL: http://maps.secondlife.com/secondlife/Shinmai/46/171/32
(global coordinates 257,582.0, 194,219.0, 31.7)
Second Life Server 16.02.17.311120
Retrieving...

CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (3491.93 MHz)
Memory: 16268 MB
OS Version: Microsoft Windows 7 64-bit Service Pack 1 (Build 7601)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: GeForce GTX 750/PCIe/SSE2

Windows Graphics Driver Version: 10.18.0013.6191
OpenGL Version: 4.5.0 NVIDIA 361.91

libcurl Version: libcurl/7.38.0 OpenSSL/1.0.1h zlib/1.2.8
J2C Decoder Version: KDU v7.2
Audio Driver Version: FMOD Ex 4.44.31
LLCEFLib/CEF Version: 1.5.3-(CEF-WIN-3.2526.1347-32)
Voice Server Version: Vivox 4.6.0017.21209

Built with MSVC version 1800
Packets Lost: 3,305/82,515 (4.0%)

[sl-service-account]

Whirly Fizzle commented at 2016-03-07T21:36:53Z

This is fixed on Second Life 4.0.2 (311770) Feb 29 2016 09:56:00 (Second Life Release)