secondlife / jira-archive

3 stars 0 forks source link

[BUG-9418] Allow global toggle of 'View People Icons' and/or restrict size of People Icons to icon size #16921

Open sl-service-account opened 9 years ago

sl-service-account commented 9 years ago

How would you like the feature to work?

Our friends' lists currently allow users to enable or disable People Icons. This is useful for disabling download of profile pics, which was recently identified (http://blog.nalates.net/2015/01/24/texture-thrashing-2015-04/) as a major contributing factor to texture thrashing.

Unfortunately, while being able to disable this in our friends list, it is not universally available throughout the UI; while a user may have hundreds of friends, they may additionally have access to view hundreds or thousands more profiles when group chat pops up and as a result, they are forced to download hundreds of huge graphics that only ever take up a tiny area on the screen.

In preferences, it would be helpful to be able to choose between viewing People Icons or not.

On our profiles, it would also be helpful to have an extra field for People Icons, limited to say... a maximum 64x64px image size, and require the viewer to load those as People Icons instead of profile pics, which are typically much larger.

Why is this feature important to you? How would it benefit the community?

As a full time content creator, I must clear cache and relog sometimes several times daily, due to the texture thrashing problem. I do not wear any of the commonly blamed in-world products; most often I am building my own low-poly avatars with efficient textures, or building lowpoly furniture, buildings or landscaping items. But because I am a member of a number of popular chat groups, it seems like I often max out my cache due to this profile loading issue. (I could conceivably wear nothing but an alpha layer and still run in to texture thrashing issues, all due to the graphic load seen via group chat).

Allowing people affected by this problem the alternative to not load these pics at all would greatly reduce performance issues - especially in light of the recently increased maximum group limit afforded to Premium members.

Attachments

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-9418 | | Summary | Allow global toggle of 'View People Icons' and/or restrict size of People Icons to icon size | | Type | New Feature Request | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Created at | 2015-06-07T19:54:35Z | | Updated at | 2016-04-25T23:44:32Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2015-11-16T06:07:50.847-0600', 'How would you like the feature to work?': "Our friends' lists currently allow users to enable or disable People Icons. This is useful for disabling download of profile pics, which was recently identified (http://blog.nalates.net/2015/01/24/texture-thrashing-2015-04/) as a major contributing factor to texture thrashing. \r\n\r\nUnfortunately, while being able to disable this in our friends list, it is not universally available throughout the UI; while a user may have hundreds of friends, they may additionally have access to view hundreds or thousands more profiles when group chat pops up and as a result, they are forced to download hundreds of huge graphics that only ever take up a tiny area on the screen. \r\n\r\nIn preferences, it would be helpful to be able to choose between viewing People Icons or not. \r\n\r\nOn our profiles, it would also be helpful to have an extra field for People Icons, limited to say... a maximum 64x64px image size, and require the viewer to load those as People Icons instead of profile pics, which are typically much larger.", 'Severity': 'Unset', 'Target Viewer Version': 'viewer-development', 'Why is this feature important to you? How would it benefit the community?': 'As a full time content creator, I must clear cache and relog sometimes several times daily, due to the texture thrashing problem. I do not wear any of the commonly blamed in-world products; most often I am building my own low-poly avatars with efficient textures, or building lowpoly furniture, buildings or landscaping items. But because I am a member of a number of popular chat groups, it seems like I often max out my cache due to this profile loading issue. (I could conceivably wear nothing but an alpha layer and still run in to texture thrashing issues, all due to the graphic load seen via group chat).\r\n\r\nAllowing people affected by this problem the alternative to not load these pics at all would greatly reduce performance issues - especially in light of the recently increased maximum group limit afforded to Premium members.', } ```
sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-11-16T12:07:51Z

The people icon global toggle was added in the MAINT-RC: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/3.8.7.307376

Aki, are you noticing an improvement at all with the texture thrashing on the Maint-RC when people icons are globally disabled? I'm using http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-bear/rev/307716/index.html to test because it has the IM crash fixed.

It seems like even with people icons globally disabled, the icon textures are still loading into memory whenever a group chat opens. Every single texture from the chatters list, even though the textures are hidden.

This is easy to see by watching the texture console as group chats open. All the people icons from that chatters list instantly get loaded into texture memory. The texture size doesn't appear to be reduced at all either. Globally hiding the people icons does not help in any way to lower texture thrashing :(

sl-service-account commented 8 years ago

aki.shichiroji commented at 2015-11-18T04:32:19Z

Ugh. I had hoped, by the suggestion in this JIRA, that implementation would be to reject download of the people icons entirely. Since learning that enabling the toggle causes crashes upon IM, I've not had occasion to try again. I will give that other build a try and report back.

If it's true that the viewer's just hiding them and not rejecting them, then the implementation completely misses the point :(

sl-service-account commented 8 years ago

aki.shichiroji commented at 2015-11-18T04:52:12Z

1) With People Icons disabled, it looks like full sized images appear to be downloading. This was a snapshot taken while loading 'Blender Users' group. (Notice the image width & height, as well as memory)

2) With People Icons enabled, small icons are downloaded. Is something being done on the back end to pre-process the icons before they get to my viewer? Or should I assume that the full size images are still being delivered (just not being seen given the time it takes for the console to chew through all those lines)?

sl-service-account commented 8 years ago

aki.shichiroji commented at 2015-11-18T05:06:34Z, updated at 2015-11-18T05:28:30Z

To be fair, attempting to recreate the same texture and memory results using other groups has been met with varying results; i have noticed a varying amount (from two to dozens) of 256,512,1024sq px graphics load, followed by a long tail of 64, 32 and 8px squared images when I open other group chat windows. It is difficult to comment otherwise without knowing the rationale behind the current implementation.

sl-service-account commented 8 years ago

aki.shichiroji commented at 2015-11-18T05:38:48Z

Immediate impressions based on the build Whirly last posted:

I was willing to give credit to the new feature for a good while; I did notice some textures reloading after zooming drastically out and back in, but was okay with that because that's not thrashing; it's just a reasonable drop down in detail due to zooming out.

However, now 45 mins in, I have noticed texture thrashing does still exist. It was noticeable after roughly 30 mins of sitting my camera in front of a single scene, not loading anything else but opening as many groups as I could (with people icons toggled off) and zooming in/out repeatedly.

I am not sure how this compares to the mainstream viewer; i suppose i could reinstall it and give it a try, however I have limited immediate time to monitor this.

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-11-22T01:03:41Z

Hmm they backed the whole thing out in Bear.

Crash fixed backed out: https://bitbucket.org/lindenlab/viewer-bear/commits/dfa4007b520ed65f2d139059d702c6afd430c91e View people icons backed out, both global switch & chat window part: https://bitbucket.org/lindenlab/viewer-bear/commits/42801c60290b8ed065f7f9ad7626b3f055ccce3b & https://bitbucket.org/lindenlab/viewer-bear/commits/f4f60a5a48adb6bc4ab1b07fe27acedadbfbefe9

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-12-01T17:38:53Z

Ref: https://bitbucket.org/andreykproductengine/viewer-iconpress/commits/9a2ffabe05a02ad19cb1fb5cab6cc9546c42845a MAINT-4018 scaling down and reducing discard for icons.

sl-service-account commented 8 years ago

aki.shichiroji commented at 2016-03-16T18:50:21Z

@Whirly : The link appears to be broken and I'm having difficulty finding the reference for that MAINT issue on the 391-blizzard page that I was forwarded to. Does your reference mean a fix is back in the works or simply that an alternative might be developed?

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2016-03-16T20:08:03Z

Heya Aki!

Try the Maint-RC viewer: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/4.0.2.312269 I think you will be very happy :) On the Maint-RC, all people icons load at 32x32 & it really does make a difference to how quickly texture thrashing starts to happen.

There is some discussion about the changes in the comments on issue BUG-11372.

sl-service-account commented 8 years ago

aki.shichiroji commented at 2016-04-25T23:39:05Z

That's good to hear. I'll have a closer look at that RC when I have a chance; Thanks!

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2016-04-25T23:44:33Z

Hey Aki!

Those changes are in the default release viewer now :) There are some fixes for problems caused by the icon changes in the new Maintenance-RC though (http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/4.0.4.314012) so best to test on that viewer.