[BUG-9454] [BigBird-RC] Using Wear to replace attachments sometimes incorrectly adds

[sl-service-account]

Steps to Reproduce

• Rez a default box on the ground, shift copy it 4 times and take all 4 box objects to inventory.

• Rename the 4 objects to:

  • Left Ear 1
  • Left Ear 2
  • Right Ear 1
  • Right Ear 2

• Attach "Left Ear 1" to the Left Ear attachment slot Right click -> Attach to -> Left Ear.

• Also attach "Left Ear 2" to the Left Ear attachment slot

• Attach both "Right Ear 1" and "Right Ear 2" to the Right Ear attachment slot.

• Detach all 4 boxes.

• Detach all other worn attachments Right click avatar -> Detach All. (Not a necessary step but make sure you have no attachments attached to Left Ear or Right Ear at this stage).

• From Inventory, Right click "Left Ear 1" -> Wear. Observe that "Left Ear 1" is correctly attached to Left Ear.

• Right click "Right Ear 1" -> Wear. Observe that "Right Ear 1" is correctly attached to Right Ear.

  

• Ctrl select both "Left Ear 2" and "Right Ear 2" so that both attachments are selected.

  

• Right click the selection -> Wear

  Observed Behaviour

• Left Ear 1 is correctly detached and replaced with Left Ear 2.

• Right Ear 1 is not detached. <--- bug

• Right Ear 2 is attached.

• You are left with Left Ear 2, Right Ear 1, Right Ear 2 attached.

  

• Relevant lines from attached log file Whirly_Log_1.log showing only Left Ear 1 being detached.

  
  2015-06-12T21:14:22Z INFO:#Avatar LLUpdateAppearanceOnDestroy::~LLUpdateAppearanceOnDestroy:  Avatar 'Whirly Fizzle' textured_and_downloaded done update appearance on destroy
  2015-06-12T21:14:22Z INFO:#Avatar LLUpdateAppearanceOnDestroy::~LLUpdateAppearanceOnDestroy:  Avatar 'Whirly Fizzle' textured_and_downloaded done update appearance on destroy
  2015-06-12T21:14:22Z INFO:#Avatar LLUpdateAppearanceOnDestroy::~LLUpdateAppearanceOnDestroy:  Avatar 'Whirly Fizzle' textured_and_downloaded done update appearance on destroy
  2015-06-12T21:14:22Z INFO:#Avatar LLWearableHoldingPattern::pollFetchCompletion:  Avatar 'Whirly Fizzle' textured_and_downloaded HP 17 polling, done status: 1 timed out 0 elapsed 0.000007s
  2015-06-12T21:14:22Z INFO:#Avatar LLWearableHoldingPattern::onAllComplete:  Avatar 'Whirly Fizzle' textured_and_downloaded HP 17 updating agent wearables with 5 wearable items 
  2015-06-12T21:14:22Z INFO: LLAgentWearables::setWearableOutfit: setWearableOutfit() start
  2015-06-12T21:14:23Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for Left Ear 1 id 614c143c-8a2a-f263-5f42-5a25de79c10a
  2015-06-12T21:14:23Z INFO:#Inventory LLInventoryModel::onAISUpdateReceived: elapsed: 0.002557s
  2015-06-12T21:14:23Z INFO:#Inventory LLInventoryModel::onAISUpdateReceived: elapsed: 0.002214s
  2015-06-12T21:14:23Z WARNING:#Inventory AISUpdate::parseMeta: removed item not found 9c6c0053-6a71-34a1-9525-17a411aea5ef
  2015-06-12T21:14:23Z WARNING: AISUpdate::doUpdate: Possible version mismatch for category Current Outfit, viewer version 127387 server version 127385
  2015-06-12T21:14:23Z INFO:#Inventory LLInventoryModel::onAISUpdateReceived: elapsed: 0.000561s

  Expected Behaviour

• Right Ear 1 should be detached and replaced with Right Ear 2 because I used "Wear" rather then "Add".

• I should be left wearing only Left Ear 2 and Right Ear 2.

  Other Information.

• Note that current default release, Second Life 3.7.29 (301305) Apr 27 2015 11:41:55 (Second Life Release), also has buggy behaviour when working through the above repro but the behaviour is different and erratic and the attachments sometimes attach correctly and then fall off and results are different each time (current release behaviour with this repro seems related to BUG-7714).

• If you test using an older viewer, for example Second Life 3.7.7 (289461) Apr 22 2014 13:01:33 (PostInteresting), then the bug does not reproduce. See the attached gif showing the correct behaviour when using 3.7.7 (289461)

Attachments

• Correct Behaviour.gif 2015-06-12 17:35:23
• Whirly_Log_1.log 2015-06-12 17:23:11

Original Jira Fields

| Field | Value | | ------------- | ------------- | | Issue | BUG-9454 | | Summary | [BigBird-RC] Using Wear to replace attachments sometimes incorrectly adds | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Reporter | Whirly Fizzle (whirly.fizzle) | | Created at | 2015-06-12T20:54:17Z | | Updated at | 2021-05-17T21:39:10Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2016-01-25T08:28:59.398-0600', 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': '...', 'What were you doing when it happened?': 'Filling in...\r\n', 'What were you expecting to happen instead?': '....', } ```

[sl-service-account]

Whirly Fizzle commented at 2015-06-17T18:08:47Z

Still reproduces on Second Life 3.7.31 (302640) Jun 15 2015 11:24:01 (Second Life Release) (Latest Big-Bird RC).

[sl-service-account]

Ansariel Hiller commented at 2016-01-25T14:28:59Z, updated at 2016-01-25T14:30:31Z

This is caused by the workaround "fix" for attachments falling of during TPs. As part of this "fix", the viewer maintains a list of attachments that it requested to be detached (LLAttachmentsMgr::mDetachRequests) and issue a re-attach in case they fall off unexpectedly.

"Wearing" objects will route the viewer into this code path:

1. Choosing wear will call rez_attachment() with replace = true for each of the objects selected to be worn
2. Since the viewer doesn't know what attachment spot each object is going to and can't detach objects occupying them itself, the sim will have to do that; therefore, the viewer cannot add attachments going to be detached to LLAttachmentsMgr::mDetachRequests
3. When the sim is processing the attachment request, it will issue a detach message for each attachment that is being replaced
4. The viewer looks up in LLAttachmentsMgr::mDetachRequests if it was caused by the viewer and doesn't find it there
5. Viewer requests an appearance update from COF and things break horribly

newview/llattachmentsmgr.cpp(529) : 2016-01-25T14:21:33Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for :GF: spring hunt sneakers R id af10b9e6-524d-a1ca-e51b-ede0df4292aa newview/llappearancemgr.cpp(3314) : 2016-01-25T14:21:33Z DEBUG:#Outfit LLAppearanceMgr::updateIsDirty: item count different - base 15 cof 16 newview/llappearancemgr.cpp(3314) : 2016-01-25T14:21:34Z DEBUG:#Outfit LLAppearanceMgr::updateIsDirty: item count different - base 15 cof 17 newview/llappearancemgr.cpp(3314) : 2016-01-25T14:21:34Z DEBUG:#Outfit LLAppearanceMgr::updateIsDirty: item count different - base 15 cof 16 newview/llinventorymodel.cpp(1353) : 2016-01-25T14:21:34Z INFO:#Inventory LLInventoryModel::onAISUpdateReceived: elapsed: 0.004037s newview/llappearancemgr.cpp(3900) : 2016-01-25T14:21:35Z WARNING:#Avatar RequestAgentUpdateAppearanceResponder::httpFailure: appearance update request failed, status 400 reason Bad Request