secondlife / jira-archive

2 stars 0 forks source link

[BUG-134170] After editing an outfit, duplicate photos appear in the Outfit Gallery for outfits that previously had no photo. #2208

Open sl-service-account opened 6 years ago

sl-service-account commented 6 years ago

Steps to Reproduce

Had just edited several outfits.

Actual Behavior

On several different occasions I've edited outfits to update the contents and upon going into the Appearance Outfit Gallery I have found that many of the outfits that previously had no photo associated with them had images placed on them from other outfits. Sometimes as many as 6 or 8 duplicate images appearing on outfits that had no previous photo.

Expected Behavior

Those outfits that were edited that previously had no photo associated with them should not have had photos from other outfits associated with them.

Other information

This is an incredible nuisance. You must wear each outfit to be certain that the image is correct and then if it is not Remove Photo from all of them.

Attachments

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-134170 | | Summary | After editing an outfit, duplicate photos appear in the Outfit Gallery for outfits that previously had no photo. | | Type | Bug | | Priority | Unset | | Status | Needs More Info | | Resolution | Unresolved | | Created at | 2017-08-23T20:15:37Z | | Updated at | 2017-09-08T17:15:30Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2017-08-24T12:12:53.507-0500', "Is there anything you'd like to add?": 'This is an incredible nuisance. You must wear each outfit to be certain that the image is correct and then if it is not Remove Photo from all of them. ', 'ReOpened Count': 0.0, 'Regression?': ['Issue is a Regression'], 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': "On several different occasions I've edited outfits to update the contents and upon going into the Appearance Outfit Gallery I have found that many of the outfits that previously had no photo associated with them had images placed on them from other outfits. Sometimes as many as 6 or 8 duplicate images appearing on outfits that had no previous photo.", 'What were you doing when it happened?': 'Had just edited several outfits. ', 'What were you expecting to happen instead?': 'Those outfits that were edited that previously had no photo associated with them should not have had photos from other outfits associated with them.', 'Where': 'http://maps.secondlife.com/secondlife/Horizons%20Atlas/245/98/25', } ```
sl-service-account commented 6 years ago

Kyle Linden commented at 2017-08-24T17:12:54Z

Hi Wendi,

Please reproduce this problem and attach the SecondLife.log data from your viewer to this issue; see https://wiki.secondlife.com/wiki/Finding_Log_Files

Please also describe exactly which method you are using to add the photos to the outfits. Screen shots or videos would be great to include.

When you update this report with this information please press the Info Provided button.

Thanks!

sl-service-account commented 6 years ago

wendi.nitely commented at 2017-08-24T20:45:44Z

For the outfits I have with photos I have, without exception, selected Take Photo.

The problem I have is not with photos I have taken being applied to the correct outfit.

The problem is that after wearing, modifying and saving an outfit - existing photos get assigned to outfits that previously had no assigned photo!

sl-service-account commented 6 years ago

Kyle Linden commented at 2017-08-25T17:23:44Z

Hi Wendi,

A few things for clarity.

  1. After modifying the outfit you are wearing are you selecting the default Save As or using the arrow to select Save?
  2. Next get the latest version of Second Life and see if you can still reproduce the problem. https://get.secondlife.com
  3. If you can still see the problem please try to capture video or screen shots of exactly which outfit gets affected by this problem.

Lastly, does the problem persist after you relaunch Second Life?

Please provide all this information and press the Info Provided button.

Thanks!

sl-service-account commented 6 years ago

wendi.nitely commented at 2017-08-25T20:46:38Z

I am using the arrow to Save - not Save As.

I am running, at the time of the error, the latest version of the client.

I am going to have to spend hours of testing to reproduce. It is only after the edit of several, if not many, outfits.

Yes, the problem persists after relaunching the client.

Thank you Kyle

sl-service-account commented 6 years ago

Kyle Linden commented at 2017-08-28T17:11:42Z

Hi Wendi,

Thank you for the additional details. We've accepted this report as a bug but so far we've not been able to reproduce it either.

I'm going to leave this issue as "Needs More Information" so that the next time you do see this happen, or if anyone else does, this issue can be updated with viewer logs of the session when it occurred.

Please press Info Provided when you update this report.

Thanks!

sl-service-account commented 6 years ago

wendi.nitely commented at 2017-08-28T20:21:11Z

Thank you Kyle, What I am going to do as soon as I see daylight is go and do several "un-necessary" outfit edits and see if I can reproduce the problem for you. Though I think all your going to see is a screen photo of the duplicated images... I don't know what else I can supply...

sl-service-account commented 6 years ago

wendi.nitely commented at 2017-08-30T19:37:56Z, updated at 2017-08-31T18:03:01Z

Kyle I happened to need to change a few outfits. It happened again. Here is a photo. Here is what I am doing... I go to the Appearance Tool, then to the My outfits tab. Then I filter on a particular item. Then for each of the resulting outfits in the list: from the My Outfits tab I wear the outfit and change an item (sometimes I am removing the item I am filtering on), then I use the drop-down Save selection (not Save As). If I've removed the filtered object from the outfit the results list changes properly. I may do a dozen outfits as I did today. Then when I go to the Outfit Gallery I find all these existing photos for outfits I have taken photos for, applied to outfits that never had a photo taken. Oops, I see I didn't wait for all outfit photos to rez, but you can see a pic on two outfits, and another pic on three outfits.

sl-service-account commented 6 years ago

Kyle Linden commented at 2017-08-31T19:32:18Z

Hi Wendi,

I just spotted a lot of inventory corruption in your account. About 7000 items, almost 10% of your inventory.

Please contact support and have them run the "Fix Inventory" tool on your account ASAP. https://support.secondlife.com/create-case/

Once that is done, please let me know if this issue with your Outfit Gallery photos keeps happening. With that much corruption in your inventory it could explain why things were not behaving correctly.

Please press Info Provided and let me know how it turns out.

Thanks!

sl-service-account commented 6 years ago

wendi.nitely commented at 2017-09-05T18:32:18Z

I contacted support and they can a script and talked me through how to reload my inventory on the Debug1 sim. I then wore all the outfits in my outfit gallery (that had photos) to be certain there were no unwanted photos. There were none, however one outfit for which there was a photo was missing the links to the clothing items, and in fact the folder containing the clothing items was missing from my inventory. I have no clue if the ~10% of my inventory that was "corrupted" was removed or corrected, but I know this one item was removed, that this one item had a legit photo - and now I suspected that something in the folder that was removed may have been causing the issues. Time will tell. ~Wendy

sl-service-account commented 6 years ago

Kyle Linden commented at 2017-09-05T21:04:47Z

Hi Wendi,

I'm sorry you were not given better information about the script's intended results. It does its best to fix everything and moves it safely to your Lost & Found folder. I have checked your account and it does appear that your total inventory count has not decreased.

Given the number of corrupt items you had, it is very plausible that one of the outfits was corrupt too.

So if that outfit was recoverable, you should be able to find it in your Lost and Found folder and then copy it back a more appropriate Clothing sub folder. I suggest deleting the broken outfit from you Outfit Gallery, then lastly, make a new outfit with the freshly recovered content.

You'll probably also need to spend some time reviewing everything in Lost & Found and moving it back into its proper subfolders.

I'll leave this issue still in "Needs More Info" for now in case this issue happens again.

Thanks!

sl-service-account commented 6 years ago

wendi.nitely commented at 2017-09-05T23:42:51Z, updated at 2017-09-06T15:55:31Z

Kyle, I wanted to let you know the resolution of my Lost and Found Folder. Without exception, every item in the Lost and found was an item that had long ago been deleted! (e.g. old versions of updated product objects or notecards). And in 90% of the cases that object or notecard was duplicated in the Lost and Found Folder ~6 to ~ 30 times.

The one oddity, and this was not found anywhere, not in trash, not in the Lost and Found Folder, was an outfit folder from Morea Style called Diana. That entire folder (that existed a few months ago when I put on the outfit and took the picture) completely vanished - not a big deal. But it was not in the Lost and Found and none of the members of the outfit was in the folder.

The odd thing that I wanted to let you know about (in case this knowledge plants a seed for another "bug" fix) is that all those items in lost and found had been long long ago deleted and (I think) purged, but definitely deleted; there was no entry in my inventory for them. They seem to have been inventory items not listed.

Thank you again, ~Wendy

sl-service-account commented 6 years ago

Grumpity Linden commented at 2017-09-06T16:52:32Z

Thanks Wendy! We've now got a repro for this bug and a fix is coming in the next Maintenance Viewer release.

For posterity, the exact steps to reproduce it:

  1. Open Outfit Gallery
  2. Right click an outfit with photo and select "Replace current outfit"(it should contain any object attachment)
  3. Click "Edit this outfit"(wrench) button
  4. Open Attachments tab and remove one object via clicking "x" button; Click Save button
  5. Click "<" arrow button to return to Outfit Gallery Now similar steps for outfit that have no associated photo
  6. Right click an outfit WITHOUT photo(but it should contain an object attachment) and select "Replace current outfit"
  7. Click "Edit this outfit"(wrench) button
  8. Open Attachments tab and remove one object via clicking "x" button
  9. Click Save button
  10. Click "<" arrow button to return to Outfit Gallery Actual result: The outfit(from step 6) now has the same image as the previous one (from step 2)
sl-service-account commented 6 years ago

Kyle Linden commented at 2017-09-08T17:15:30Z

Hi Wendi,

Thanks for the update. The corruption fix is not perfect but it looks like it recovered everything that was actually corrupt. In your case it looks like you had lots of corrupt trash. Sorry that's what was sent to Lost and Found. I'm sorry that it looks like that one outfit folder was not recovered, but hopefully now you can rebuild it cleanly and avoid future inventory corruption.

Grumpity's comment above does show the steps to reproduce this issue and we are going to fix it soon!

Thanks for working with us to sort this out. I'm leaving this Jira in the Needs More Info state only if you find future issues. You do not need to reply otherwise.

Thanks!