search

secondlife / jira-archive

2 stars 0 forks source link

[BUG-225478] [Animesh] Certain HUDs collapse when zooming #4267

Open sl-service-account opened 6 years ago

sl-service-account commented 6 years ago

What just happened?

Obtain a copy of this free HUD from the Marketplace

https://marketplace.secondlife.com/p/The-Life2-HUD-FREE-Bring-Life-to-your-Second-Life-Hunger-Thirst-Jobs-Farming-Cooking-MUCH-More/11190136

What were you doing when it happened?

Simply attach the HUD as you normally would. 

Pan your camera around and zoom out and watch the HUD collapse. 

What were you expecting to happen instead?

HUDs should not collapse onscreen. 

Other information

Animesh Viewer - HUD collapses  https://gyazo.com/e961cad1793fbdf42819b4ce8d85a0c0  

 

Attachments

Links

Related

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-225478 | | Summary | [Animesh] Certain HUDs collapse when zooming | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Reporter | Willow Wilder (willow.wilder) | | Created at | 2018-09-16T12:04:22Z | | Updated at | 2018-09-20T02:42:57Z | ``` { 'Build Id': 'unset', 'Business Unit': ['Platform'], 'Date of First Response': '2018-09-16T08:20:38.120-0500', "Is there anything you'd like to add?": '..', 'Original Reporter': 'Willow Wilder (willow.wilder)', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': '..', 'What were you doing when it happened?': '..', 'What were you expecting to happen instead?': '..', 'Where': 'http://maps.secondlife.com/secondlife/Testylvania%20Sandbox/208/96/22', } ```
sl-service-account commented 6 years ago

Whirly Fizzle commented at 2018-09-16T13:20:38Z

Bug only reproduces on Animesh viewers. Does not reproduce on LL default release. Bug also reproduces on Firestorm Animesh beta viewer.

sl-service-account commented 6 years ago

Willow Wilder commented at 2018-09-16T20:35:12Z

Also >MM< HUD Tweenster V3.04 DEMO https://marketplace.secondlife.com/p/MM-HUD-Tweenster-V304-DEMO/15159417

https://gyazo.com/a5cd13f7a6157d40ef88243f4a6a3310

sl-service-account commented 6 years ago

Whirly Fizzle commented at 2018-09-16T21:24:16Z

Also affects:

sl-service-account commented 6 years ago

Whirly Fizzle commented at 2018-09-16T21:27:22Z

It's easy to repro with 2 default spheres linked & attached to a HUD point. https://gyazo.com/99c1d2c76c8af2cf7388de1a9ef060cf

sl-service-account commented 6 years ago

Lucia Nightfire commented at 2018-09-16T22:01:08Z

Another "must fix" bug for Vir, heh.

sl-service-account commented 5 years ago

Beq Janus commented at 2018-09-17T10:55:54Z

The problem appears to stem from a change in lldrawable which affects the drawable distance calc for any object that has a parent avatar. 

Using the (repaired) LODInfo display in Firestorm you can quickly see that the mDistanceWrtToCamera is no longer constant, were on the current release viewers it is.

Both videos use a simple 0.5m sphere attached to Centre HUD

Animesh viewer : https://i.gyazo.com/128fd9095bdf254f1e2559738e5829de.mp4

FS Release : https://i.gyazo.com/68884676b7e045a24247d849a483b94b.mp4

 

I have fixed this in Firestorm axon pre-release with the attached patch, however, I would note a couple of things.

1) The code was explicitly changed prior to this update to apply the new calculation to all avatars, not just CAVs. This means that it no longer applies just to Animesh (in spite of the code comment) and thus catch HUDs and all other wearables. I do not know whether this was a deliberate update to deal with another issue and thus I have not reinstated the CAV check.

2) I am explicitly checking for HUDs and excluding them, this means that all other attachments are now affected by the revised distance calculation and this will have knock-on effects on the visibility of some attachments. 

 

The better "fix" to this would appear to be to reinstate the CAV only exclusion, but not knowing the reason it was removed I have for now gone with the more explicit HUD fix.

 

Regards

Beq

sl-service-account commented 5 years ago

Vir Linden commented at 2018-09-17T20:10:19Z

The change to use updated bounding boxes with all avatars is intentional, to fix a range of longstanding bugs/exploits in the old bounding box code. Collapsing HUDs is certainly not desired though.

sl-service-account commented 5 years ago

Whirly Fizzle commented at 2018-09-17T20:31:24Z

@Vir A related problem that only repros on Animesh viewers. BUG-225485

I hope this isn't intended. Any unrigged attachment that you attach while camera is fairly close to your avatar stays stuck at low LOD till you zoom camera out & back. This isn't the occasionaly stuck LOD bug that happens on non-Animesh viewers, it repros on 100% of attempts.

This is a default sphere attached to my head. It never fully rezzes in until I zoom camera out: https://gyazo.com/11c539452cf252611f04b0aa56d7b220 Same problem with unrigged mesh hair: https://prnt.sc/kvj41m

sl-service-account commented 5 years ago

Beq Janus commented at 2018-09-18T12:59:17Z

@Vir given the intention stated in the comment around SL-937 (see lldrawable.cpp) 

If we change my patch from testing got huds to testing for rigged mesh that should give use a fix for wider issue (see below what I propose for FS). I'll drop you a note though.

 

if (volume->getAvatar() && volume->mDrawable->isState(LLDrawable::RIGGED))

sl-service-account commented 5 years ago

Kadah Coba commented at 2018-09-20T02:42:57Z

The HUD from the Kemono was repoing this.

https://marketplace.secondlife.com/p/UTILIZATOR-Kemono/6070005

 

Interesting that only some HUDs get effected.