secondlife / jira-archive

2 stars 0 forks source link

[BUG-226390] Consider switching BOOST_FOREACH with C++11 "for" variant #4943

Closed sl-service-account closed 7 months ago

sl-service-account commented 5 years ago

How would you like the feature to work?

example: BOOST_FOREACH(LLView* viewp, mChildList) to for (LLView* viewp : mChildList)

Why is this feature important to you? How would it benefit the community?

BOOST_FOREACH is supposedly couple percents slower then 'hand made' variant (from https://www.boost.org/doc/libs/1_65_1/doc/html/foreach.html) Replacing it with native C++ supported variant might allow some better compiler optimizations and closer perfomance to 'hand made' variant. But this needs confirmation.

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-226390 | | Summary | Consider switching BOOST_FOREACH with C++11 "for" variant | | Type | New Feature Request | | Priority | Unset | | Status | Closed | | Resolution | Unactionable | | Labels | code | | Reporter | AndreyK ProductEngine (andreyk.productengine) | | Created at | 2019-02-20T18:46:27Z | | Updated at | 2019-02-20T19:19:27Z | ``` { 'Build Id': 'unset', 'Business Unit': ['Platform'], 'Date of First Response': '2019-02-20T13:19:27.080-0600', 'How would you like the feature to work?': 'example:\r\nBOOST_FOREACH(LLView* viewp, mChildList)\r\nto\r\nfor (LLView* viewp : mChildList)', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'Target Viewer Version': 'viewer-development', 'Why is this feature important to you? How would it benefit the community?': "BOOST_FOREACH is supposedly couple percents slower then 'hand made' variant (from https://www.boost.org/doc/libs/1_65_1/doc/html/foreach.html)\r\nReplacing it with native C++ supported variant might allow some better compiler optimizations. But this needs confirmation.", } ```
sl-service-account commented 5 years ago

Kyle Linden commented at 2019-02-20T19:19:27Z

Hi Andrey,

Thank you for your suggestion. We've reviewed your request and determined that it is not something we can tackle at this time.

Please be assured that we truly appreciate the time you invested in creating this feature request, and have given it thoughtful consideration among our review team. This wiki outlines some of the reasoning we use to determine which requests we can, or can't, take on: http://wiki.secondlife.com/wiki/Feature_Requests

Thanks again for your interest in improving Second Life.