sl-service-account
commented
5 years ago HunniHope commented at 2019-05-09T15:43:52Z
Just going to toss my tuppence into the wishpool. Having seen this I like the moon glow, so please don't fix it by getting rid of it, instead fix it by adding new options for moon glow instead of it picking up sun left-overs
Steps To Reproduce
This bug reproduces with any sky, even when editing the default new sky.
I created a sky to easily show this bug but it isn't necessary to use it to reproduce.
Apply the sky "BUG-226962 - repro sky - Moon glow/focus" - Applying locally is fine.
Repro sky passed to Rider Linden, Graham Linden, Kyle Linden, Alexa Linden, Dan Linden, Geenz Spad.
Edit the repro sky locally or if you applied it to a parcel/region, customize it via About Land or Region/Estate.
Observe that the sun is above the horizon and the moon is below the horizon.
Look at the sun & observe that the sun Glow Focus & Glow size are working correctly & you can visibly see the changes to the sun when tweaking those settings.
Now edit the moon position so the moon appears above the horizon (Use the N arrow for Moon position) & observe what happens to the sun Glow Focus & Glow size once the moon appears above the horizon.
Observe that once the moon is visible in the sky & above the horizon, the glow size around the sun visibly gets smaller.
See Fig 1 gif attached.
While the moon is still above the horizon, edit the sun below the horizon (Use the S arrow to move the sun).
Observe that as soon as the sun is below the horizon & no longer visible in the sky, the moon geta a glow around it.
The glow around the moon is the sun Glow Focus & Glow size settings & by changing these settings you can see they affect the glow around the moon.
See Fig 2 & Fig 3 attached.
Observed Behaviour
When the moon is below the horizon, the glow around the sun looks correct.
If both the moon & sun are above the horizon, the glow around the sun gets smaller (Fig 1).
If the sun is below the horizon, the moon has the sun Glow Focus & Glow size settings incorrectly applied (Fig 2 & Fig 3).
Bug reproduces when the sun & moon are at any position above or below the horizon - I just had both bodies set low on the horizon in the test sky to make the bug easier to see.
Expected Behaviour
Sun Glow Focus & Glow size settings should not change for the sun when the moon is also above the horizon.
Sun Glow Focus & Glow size settings should not affect the moon when the sun is below the horizon.
I should be able to both the sun & the moon visible in the sky without things getting funky.
After thinking about this further - maybe this is (or should be) a feature? Though note the bug only partially reproduces in the current EEP-RC viewer (see other information).
If you are creating a fixed sky with both astral bodies visible in the sky, you can easily work around the Fig 1 bug by tweaking the sun Glow Focus & Glow size settings. Plus if only the moon is visible in the sky, this "bug" gives you extra settings to set an optional glow round the moon.
If you are creating a day cycle, you can adjust each sky frame as above.
Can anyone think of a disadvantage to not fixing this? :D
Other information
Bug reproduces on latest EEP Nightly: Second Life Release 6.2.2.526976 (64bit)
Bug partially reproduces on the current EEP-RC viewer: Second Life Release 6.2.0.526104 (64bit)
Bug does not reproduce on legacy viewers, but note that you cannot have both astral bodies visible in the sky on legacy viewers.
Attachments
Original Jira Fields
| Field | Value | | ------------- | ------------- | | Issue | BUG-226962 | | Summary | [EEP] Sun Glow Focus & Glow Size appear round the moon & other oddities | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Labels | whirly-eep | | Reporter | Whirly Fizzle (whirly.fizzle) | | Created at | 2019-05-09T08:45:21Z | | Updated at | 2020-06-15T15:23:02Z | ``` { 'Build Id': 'unset', 'Business Unit': ['Platform'], 'Date of First Response': '2019-05-09T10:43:52.350-0500', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': 'Filling in...', 'What were you doing when it happened?': '.....', 'What were you expecting to happen instead?': '.....', 'Where': 'Any region', } ```