secondlife / jira-archive

2 stars 0 forks source link

[BUG-227500] [Improvement] CLICK_TOUCH_DISABLED needs server side support. #5770

Open sl-service-account opened 5 years ago

sl-service-account commented 5 years ago

Information

CLICK_TOUCH_DISABLED was implemented in the viewer last year but only viewer side.

A UI change with the build menu "Click to: " allowed setting the "None" status which is value 8 at the server level.

Older/Illegal viewers are still able to bypass this and trigger touch events in objects that have this status.

The server needs to enforce this status and not trigger touch events in links that have this status or pass on touches to the root.

The script library needs to have the CLICK_TOUCH_DISABLED integer constant created.

The wiki page for llSetClickAction() needs to be updated with this new value.

Other Information

Something else that should probably be enforced is a bounds check against what llSetClickAction() and even the viewer can set.

The server should only accept values between 0 & 8. Anything else should be ignored. Currently, any integer can be used.

This is for the sake of future additions that might be tied to more secure, permissions-based or limited operation.

 

Links

Related

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-227500 | | Summary | [Improvement] CLICK_TOUCH_DISABLED needs server side support. | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Reporter | Lucia Nightfire (lucia.nightfire) | | Created at | 2019-08-16T10:36:41Z | | Updated at | 2020-05-11T15:23:21Z | ``` { 'Build Id': 'unset', 'Business Unit': ['Platform'], 'Date of First Response': '2019-08-21T13:29:32.458-0500', 'How would you like the feature to work?': 'CLICK_TOUCH_DISABLED was implemented in the viewer last year but only viewer side.\r\n\r\nA UI change with the build menu "Click to: " allowed setting the "None" status which is value 8 at the server level.\r\n\r\nOlder/Illegal viewers are still able to bypass this and trigger touch events in objects that have this status.\r\n\r\nThe server needs to enforce this status and not trigger touch events in links that have this status or pass on touches to the root.\r\n\r\nThe script library needs to have the CLICK_TOUCH_DISABLED integer constant created.\r\n\r\nThe wiki page for llSetClickAction() needs to be updated with this new value.', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Simulator', 'Target Viewer Version': 'viewer-development', 'What just happened?': '.', 'What were you doing when it happened?': '.', 'What were you expecting to happen instead?': '.', 'Why is this feature important to you? How would it benefit the community?': '?', } ```
sl-service-account commented 5 years ago

Kyle Linden commented at 2019-08-21T18:29:32Z

This is a valid Server bug. Moved out of Feature Request queue.