secondlife / jira-archive

2 stars 0 forks source link

[BUG-229735] Scripted agents can no longer log in #7551

Closed sl-service-account closed 5 months ago

sl-service-account commented 3 years ago

What just happened?

I operate Triple Labs, and market a HUD that helps 1000's of residents navigate through SL. Some of the data it needs is collected by a scripted agent, but after yesterday's Login maintenance he can no longer log in. Using Firestorm to log in that agent is successful.

What were you doing when it happened?

Trying to log in an Open Metaverse scripted agent that has been successfully logging in for the last 10 years. The agent immediately returns "Login error" upon connecting.

What were you expecting to happen instead?

The scripted agents in SL that are using Open Metaverse should still be allowed to log in.

Other information

Links

Related

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-229735 | | Summary | Scripted agents can no longer log in | | Type | Bug | | Priority | Unset | | Status | Closed | | Resolution | Triaged | | Created at | 2020-11-25T14:28:28Z | | Updated at | 2020-12-02T20:06:12Z | ``` { 'Build Id': 'unset', 'Business Unit': ['Platform'], 'Date of First Response': '2020-11-25T09:14:18.991-0600', 'ReOpened Count': 0.0, 'Regression?': ['Issue is a Regression'], 'Severity': 'Unset', 'System': 'SL Simulator', 'Target Viewer Version': 'viewer-development', 'What just happened?': "I operate Triple Labs, and market a HUD that helps 1000's of residents navigate through SL. Some of the data it needs is collected by a scripted agent, but after yesterday's Login maintenance he can no longer log in. Using Firestorm to log in that agent is successful.", 'What were you doing when it happened?': 'Trying to log in an Open Metaverse scripted agent that has been successfully logging in for the last 10 years. The agent immediately returns "Login error" upon connecting.', 'What were you expecting to happen instead?': 'The scripted agents in SL that is using Open Metaverse should still be allowed to log in.', } ```
sl-service-account commented 3 years ago

Oz Linden commented at 2020-11-25T15:14:19Z

We'll need more to go on than this. Can you specify a particular agent that is unable to log in and an approximate time when it was attempted? (you can set the access on the comment to 'lindens')

sl-service-account commented 3 years ago

triple.peccable commented at 2020-11-25T15:23:54Z

Hi Oz. I use 2 bots, Joebob Nootan and JD Markstein. They were operating normally during yesterday's login maintenance. But after disconnecting from their sessions, neither can log in.  I tried several times during the day, and again this morning.  I just now tried, so the exact time was 7:19 SLT, the agent was JD Markstein. The message received was "Login error:" with nothing after the colon.

sl-service-account commented 3 years ago

Oz Linden commented at 2020-11-25T16:38:48Z

I've found the error in the logs; looking to see if there is a workaround to suggest...

sl-service-account commented 3 years ago

triple.peccable commented at 2020-11-25T17:13:08Z

Thanks. Shortly after you accepted this bug, all of my HTTP requests started failing, and are continuing to do so. Is this related to your investigations?

sl-service-account commented 3 years ago

Oz Linden commented at 2020-11-25T17:35:03Z

not that I know of

I've diagnosed the failure, and don't have a workaround, but I'll try to fast-track the fix.

sl-service-account commented 3 years ago

Cinder Roxley commented at 2020-11-25T18:18:38Z

Note that LibOMV has essentially abandoned support for Second Life.

This issue is not reproducible using LibreMetaverse library which maintains up to date protocol support for Second Life. You may consider using LibreMetaverse in place of OMV for the future. It's not a drop-in replacement, but the transition is pretty easy to make and the benefits (like AIS3 support) are well worth it.

sl-service-account commented 3 years ago

Cinder Roxley commented at 2020-11-25T18:23:16Z

Further, I am assuming this was an issue I ran into several months ago testing on Aditi with LibreMetaverse/Radegast. "OSD" LibOMV's LLVM implementation does not handle the login response properly due to a bug in the underlying XMLRPC library. The login response IS valid per spec. This issue was resolved in LibreMetaverse.

If you would rather hack through this with OMV, you can build LibOMV linked against my XMLRPC fork where the fix lives: https://github.com/cinderblocks/XmlRpcCore/commit/5cc5a073f78cbf69995f25a16758ebd972fb45d6

sl-service-account commented 3 years ago

triple.peccable commented at 2020-11-25T19:28:55Z, updated at 2020-11-25T19:29:11Z

Thank you Cinder!

For now I really need to hack through this, because the HUD is undergoing a major rewrite, with plans to update the scripted agents at that time. But RL keeps interfering so the upgrade is way behind schedule. That is why I really, really appreciate Oz's efforts in getting a fixed pushed through.

I have to believe I'm not the only one left using OMV, so Oz's efforts are probably worth it even if I successfully use your fork to build/link and login with my highly modified LibOMV code. Fingers crossed that both happens. :)

sl-service-account commented 3 years ago

Oz Linden commented at 2020-11-25T20:20:49Z

Alas, you are not the only one (but you're the only one to create a Jira - THANK YOU)

Because of the impending holiday, this can't get out before Monday, but I'm trying to get it ready

sl-service-account commented 3 years ago

Oz Linden commented at 2020-11-25T20:50:29Z

I'm sure that upgrading as Cinder recommends is a Very Good Idea, but the failure in login is definitely a real bug anyway.

sl-service-account commented 3 years ago

Oz Linden commented at 2020-11-26T14:41:51Z

A fix has been deployed to the aditi grid.

[~M.Peccable] I believe that your users have been copied to the aditi grid, so you should be able to test there.

Everyone is offline for the US Thanksgiving holiday, so any communication will be very slow at best.

sl-service-account commented 3 years ago

Oz Linden commented at 2020-12-01T15:37:37Z

Another updated fix has been deployed to aditi; please test your logins there.

We believe this update corrects the problems with older versions logging in, but would very much appreciate confirmation or problem reports (here)

sl-service-account commented 3 years ago

triple.peccable commented at 2020-12-01T16:26:42Z

I did recompile my code for aditi, but I have no way to tell if it is working properly.

That being said, I attempted to login JD Markstein without success, but I cannot login that avatar to aditi even with the standard SL viewer for some reason ("Despite our best efforts, something has gone wrong" error).

So around 8:10 to 8:20 AM SLT I attempted to login M Peccable and Electric Tungsten to aditi using OpenMetaverse, but got the same error as last week ("Login error:"). Both of those agents can successfully login to aditi using the standard SL viewer.

Please check the logs, because I cannot be 100% sure the login attempts from OpenMetaverse are actually making to aditi.

sl-service-account commented 3 years ago

triple.peccable commented at 2020-12-01T16:45:12Z

UPDATE - I found the aditi login issue on my end, and can now successfully log in to aditi with OpenMetaverse. Thank you!

sl-service-account commented 3 years ago

Bugsly Linden commented at 2020-12-02T07:39:10Z

hey [~M.Peccable] We ended up deploying one more fix. Can you please try again on your end, I want to confirm we didn't break anything for you. Thank you!

sl-service-account commented 3 years ago

triple.peccable commented at 2020-12-02T15:12:11Z

Hey Bugsly, you did good. I can still log into aditi with an OpenMetaverse scripted agent. :)

sl-service-account commented 3 years ago

Oz Linden commented at 2020-12-02T20:06:13Z

Fix has been deployed to the main grid